Merge pull request #76777 from cwdsuzhou/useless_caller

Change some code place to void useless caller

Merge pull request #76777 from cwdsuzhou/useless_caller
5f3152e2 · Kubernetes Prow Robot · GitHub · 5a790bce · 44860218 · 5f3152e2
Unverified Commit 5f3152e2 authored Apr 24, 2019 by Kubernetes Prow Robot Committed by GitHub Apr 24, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

predicates.go pkg/scheduler/algorithm/predicates/predicates.go +1 -1

No files found.
--- a/pkg/scheduler/algorithm/predicates/predicates.go
+++ b/pkg/scheduler/algorithm/predicates/predicates.go
@@ -1298,11 +1298,11 @@ func getMatchingAntiAffinityTopologyPairsOfPod(newPod *v1.Pod, existingPod *v1.P

 	topologyMaps := newTopologyPairsMaps()
 	for _, term := range GetPodAntiAffinityTerms(affinity.PodAntiAffinity) {
-		namespaces := priorityutil.GetNamespacesFromPodAffinityTerm(existingPod, &term)
 		selector, err := metav1.LabelSelectorAsSelector(term.LabelSelector)
 		if err != nil {
 			return nil, err
 		}
+		namespaces := priorityutil.GetNamespacesFromPodAffinityTerm(existingPod, &term)
 		if priorityutil.PodMatchesTermsNamespaceAndSelector(newPod, namespaces, selector) {
 			if topologyValue, ok := node.Labels[term.TopologyKey]; ok {
 				pair := topologyPair{key: term.TopologyKey, value: topologyValue}