Merge pull request #40621 from timothysc/daemonset_dos

Automatic merge from submit-queue Decrease Daemonset burst replicas due to DoS conditions. **What this PR does / why we need it**: We are seeing DoS conditions on our Registry if were running a large cluster with too many daemonsets bursting at once. **Special notes for your reviewer**: I decided not to plumb through yet another variable to the command line. Ideally such parameters could be tweaked via a configuration file. **Release note**: ```release-note NONE ```

Merge pull request #40621 from timothysc/daemonset_dos
597e938e · Kubernetes Submit Queue · GitHub · 3897fc00 · 52bedaf4 · 597e938e
Commit 597e938e authored Jan 28, 2017 by Kubernetes Submit Queue Committed by GitHub Jan 28, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

daemoncontroller.go pkg/controller/daemon/daemoncontroller.go +2 -3

No files found.
--- a/pkg/controller/daemon/daemoncontroller.go
+++ b/pkg/controller/daemon/daemoncontroller.go
@@ -51,9 +51,8 @@ const (
 	// Daemon sets will periodically check that their daemon pods are running as expected.
 	FullDaemonSetResyncPeriod = 30 * time.Second // TODO: Figure out if this time seems reasonable.

-	// Realistic value of the burstReplica field for the replication manager based off
-	// performance requirements for kubernetes 1.0.
-	BurstReplicas = 500
+	// The value of 250 is chosen b/c values that are too high can cause registry DoS issues
+	BurstReplicas = 250

 	// If sending a status upate to API server fails, we retry a finite number of times.
 	StatusUpdateRetries = 1