Skip to content

K
k3s
Commit 59541e94 authored by Nikhil Jindal's avatar Nikhil Jindal
Browse files
Options

Merge pull request #4493 from yujuhong/stray_defaults

Remove obsolete defaulting in service/rest.go
parents b339882d 9e72ec02
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 4 deletions
pkg/registry/service/rest.go
View file @ 59541e94
...@@ -127,11 +127,7 @@ func (rs *REST) Create(ctx api.Context, obj runtime.Object) (runtime.Object, err ...@@ -127,11 +127,7 @@ func (rs *REST) Create(ctx api.Context, obj runtime.Object) (runtime.Object, err
if err != nil { if err != nil {
return nil, err return nil, err
} }
// TODO: We should be able to rely on valid input, and not do defaulting here.
var affinityType api.AffinityType = service.Spec.SessionAffinity var affinityType api.AffinityType = service.Spec.SessionAffinity
if affinityType == "" {
affinityType = api.AffinityTypeNone
}
if len(service.Spec.PublicIPs) > 0 { if len(service.Spec.PublicIPs) > 0 {
for _, publicIP := range service.Spec.PublicIPs { for _, publicIP := range service.Spec.PublicIPs {
_, err = balancer.CreateTCPLoadBalancer(service.Name, zone.Region, net.ParseIP(publicIP), service.Spec.Port, hostsFromMinionList(hosts), affinityType) _, err = balancer.CreateTCPLoadBalancer(service.Name, zone.Region, net.ParseIP(publicIP), service.Spec.Port, hostsFromMinionList(hosts), affinityType)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment