Fix DaemonSet namespace handling for predicates

In order to determine whether a node should run its daemon pod, DaemonController creates a dummy pod based on DaemonSet's template and then uses scheduler predicates (currently GeneralPredicates) to test whether such pod can be run by the node. The problem was that DaemonController was not setting Namespace for the dummy pod. This was not affecting currently used GeneralPredicates but this problem could bite later when some namespace-dependent predicates are added to GeneralPredicates or directly to DaemonController's node checks (e.g. pod affinity). Stumbled upon it while working on e2e test for #31136

Fix DaemonSet namespace handling for predicates
5651f822 · Ivan Shvedunov · 273f02c8 · 5651f822
Commit 5651f822 authored Sep 26, 2016 by Ivan Shvedunov
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

daemoncontroller.go pkg/controller/daemon/daemoncontroller.go +1 -0

No files found.
--- a/pkg/controller/daemon/daemoncontroller.go
+++ b/pkg/controller/daemon/daemoncontroller.go
@@ -650,6 +650,7 @@ func (dsc *DaemonSetsController) nodeShouldRunDaemonPod(node *api.Node, ds *exte
 	}

 	newPod := &api.Pod{Spec: ds.Spec.Template.Spec, ObjectMeta: ds.Spec.Template.ObjectMeta}
+	newPod.Namespace = ds.Namespace
 	newPod.Spec.NodeName = node.Name

 	pods := []*api.Pod{}