Commit 5503e5e6 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #39413 from zdj6373/cinder

Automatic merge from submit-queue (batch tested with PRs 39433, 39413) "Attach" function records information collation In the "attach" function, the log information, for the variable "instanceid", has been described as "node", as well as recorded as "instance", recorded as "instance" should be better.
parents 13780bba 84316ad5
...@@ -83,17 +83,17 @@ func (attacher *cinderDiskAttacher) Attach(spec *volume.Spec, nodeName types.Nod ...@@ -83,17 +83,17 @@ func (attacher *cinderDiskAttacher) Attach(spec *volume.Spec, nodeName types.Nod
if err != nil { if err != nil {
// Log error and continue with attach // Log error and continue with attach
glog.Warningf( glog.Warningf(
"Error checking if volume (%q) is already attached to current node (%q). Will continue and try attach anyway. err=%v", "Error checking if volume (%q) is already attached to current instance (%q). Will continue and try attach anyway. err=%v",
volumeID, instanceid, err) volumeID, instanceid, err)
} }
if err == nil && attached { if err == nil && attached {
// Volume is already attached to node. // Volume is already attached to instance.
glog.Infof("Attach operation is successful. volume %q is already attached to node %q.", volumeID, instanceid) glog.Infof("Attach operation is successful. volume %q is already attached to instance %q.", volumeID, instanceid)
} else { } else {
_, err = attacher.cinderProvider.AttachDisk(instanceid, volumeID) _, err = attacher.cinderProvider.AttachDisk(instanceid, volumeID)
if err == nil { if err == nil {
glog.Infof("Attach operation successful: volume %q attached to node %q.", volumeID, instanceid) glog.Infof("Attach operation successful: volume %q attached to instance %q.", volumeID, instanceid)
} else { } else {
glog.Infof("Attach volume %q to instance %q failed with %v", volumeID, instanceid, err) glog.Infof("Attach volume %q to instance %q failed with %v", volumeID, instanceid, err)
return "", err return "", err
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment