Skip to content

K
k3s
Unverified Commit 52e0d5a9 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #64250 from hzxuzhonghu/clean-code

Automatic merge from submit-queue (batch tested with PRs 63319, 64248, 64250, 63890, 64233). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. replace `__internal` with runtime.APIVersionInternal **What this PR does / why we need it**: Replace `__internal` with runtime.APIVersionInternal **Release note**: ```release-note NONE ```
parents 696430dd 6f76247e
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 9 deletions
staging/src/k8s.io/apimachinery/pkg/runtime/scheme.go
View file @ 52e0d5a9
...@@ -122,7 +122,7 @@ func (s *Scheme) nameFunc(t reflect.Type) string { ...@@ -122,7 +122,7 @@ func (s *Scheme) nameFunc(t reflect.Type) string {
for _, gvk := range gvks { for _, gvk := range gvks {
internalGV := gvk.GroupVersion() internalGV := gvk.GroupVersion()
internalGV.Version = "__internal" // this is hacky and maybe should be passed in internalGV.Version = APIVersionInternal // this is hacky and maybe should be passed in
internalGVK := internalGV.WithKind(gvk.Kind) internalGVK := internalGV.WithKind(gvk.Kind)
if internalType, exists := s.gvkToType[internalGVK]; exists { if internalType, exists := s.gvkToType[internalGVK]; exists {
......
staging/src/k8s.io/apimachinery/pkg/runtime/serializer/versioning/versioning_test.go
View file @ 52e0d5a9
...@@ -129,25 +129,25 @@ func TestDecode(t *testing.T) { ...@@ -129,25 +129,25 @@ func TestDecode(t *testing.T) {
}{ }{
{ {
serializer: &mockSerializer{actual: gvk1}, serializer: &mockSerializer{actual: gvk1},
convertor: &checkConvertor{groupVersion: schema.GroupVersion{Group: "other", Version: "__internal"}}, convertor: &checkConvertor{groupVersion: schema.GroupVersion{Group: "other", Version: runtime.APIVersionInternal}},
expectedGVK: gvk1, expectedGVK: gvk1,
decodes: schema.GroupVersion{Group: "other", Version: "__internal"}, decodes: schema.GroupVersion{Group: "other", Version: runtime.APIVersionInternal},
}, },
{ {
serializer: &mockSerializer{actual: gvk1, obj: decodable1}, serializer: &mockSerializer{actual: gvk1, obj: decodable1},
convertor: &checkConvertor{in: decodable1, obj: decodable2, groupVersion: schema.GroupVersion{Group: "other", Version: "__internal"}}, convertor: &checkConvertor{in: decodable1, obj: decodable2, groupVersion: schema.GroupVersion{Group: "other", Version: runtime.APIVersionInternal}},
expectedGVK: gvk1, expectedGVK: gvk1,
sameObject: decodable2, sameObject: decodable2,
decodes: schema.GroupVersion{Group: "other", Version: "__internal"}, decodes: schema.GroupVersion{Group: "other", Version: runtime.APIVersionInternal},
}, },
// defaultGVK.Group is allowed to force a conversion to the destination group // defaultGVK.Group is allowed to force a conversion to the destination group
{ {
serializer: &mockSerializer{actual: gvk1, obj: decodable1}, serializer: &mockSerializer{actual: gvk1, obj: decodable1},
defaultGVK: &schema.GroupVersionKind{Group: "force"}, defaultGVK: &schema.GroupVersionKind{Group: "force"},
convertor: &checkConvertor{in: decodable1, obj: decodable2, groupVersion: schema.GroupVersion{Group: "force", Version: "__internal"}}, convertor: &checkConvertor{in: decodable1, obj: decodable2, groupVersion: schema.GroupVersion{Group: "force", Version: runtime.APIVersionInternal}},
expectedGVK: gvk1, expectedGVK: gvk1,
sameObject: decodable2, sameObject: decodable2,
decodes: schema.GroupVersion{Group: "force", Version: "__internal"}, decodes: schema.GroupVersion{Group: "force", Version: runtime.APIVersionInternal},
}, },
// uses direct conversion for into when objects differ // uses direct conversion for into when objects differ
{ {
...@@ -184,10 +184,10 @@ func TestDecode(t *testing.T) { ...@@ -184,10 +184,10 @@ func TestDecode(t *testing.T) {
into: &runtime.VersionedObjects{Objects: []runtime.Object{}}, into: &runtime.VersionedObjects{Objects: []runtime.Object{}},
serializer: &mockSerializer{actual: gvk1, obj: decodable1}, serializer: &mockSerializer{actual: gvk1, obj: decodable1},
convertor: &checkConvertor{in: decodable1, obj: decodable2, groupVersion: schema.GroupVersion{Group: "other", Version: "__internal"}}, convertor: &checkConvertor{in: decodable1, obj: decodable2, groupVersion: schema.GroupVersion{Group: "other", Version: runtime.APIVersionInternal}},
expectedGVK: gvk1, expectedGVK: gvk1,
expectedObject: &runtime.VersionedObjects{Objects: []runtime.Object{decodable1, decodable2}}, expectedObject: &runtime.VersionedObjects{Objects: []runtime.Object{decodable1, decodable2}},
decodes: schema.GroupVersion{Group: "other", Version: "__internal"}, decodes: schema.GroupVersion{Group: "other", Version: runtime.APIVersionInternal},
}, },
// decode into the same version as the serialized object // decode into the same version as the serialized object
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment