Commit 52d81606 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #41838 from apprenda/kubeadm_fixed_token_String

Automatic merge from submit-queue (batch tested with PRs 41540, 41808, 41710, 41838, 41840) kubeadm: update token to use '.' in discovery pkg **What this PR does / why we need it**: While working on getting https://github.com/kubernetes/community/pull/381 implemented, I noticed the kubeadm discovery pkg was printing out tokens incorrectly. Corrected and fixed up corresponding test. **Special notes for your reviewer**: /cc @luxas @jbeda **Release note**: ```release-note NONE ```
parents d81ba2c6 389e065e
...@@ -46,7 +46,7 @@ func (d *discoveryValue) String() string { ...@@ -46,7 +46,7 @@ func (d *discoveryValue) String() string {
case d.v.File != nil: case d.v.File != nil:
return "file://" + d.v.File.Path return "file://" + d.v.File.Path
case d.v.Token != nil: case d.v.Token != nil:
return fmt.Sprintf("token://%s:%s@%s", d.v.Token.ID, d.v.Token.Secret, strings.Join(d.v.Token.Addresses, ",")) return fmt.Sprintf("token://%s.%s@%s", d.v.Token.ID, d.v.Token.Secret, strings.Join(d.v.Token.Addresses, ","))
default: default:
return "unknown" return "unknown"
} }
......
...@@ -60,7 +60,7 @@ func TestNewDiscoveryValue(t *testing.T) { ...@@ -60,7 +60,7 @@ func TestNewDiscoveryValue(t *testing.T) {
Addresses: []string{"foobar"}, Addresses: []string{"foobar"},
}, },
}, },
}, expect: "token://foo:bar@foobar", }, expect: "token://foo.bar@foobar",
}, },
} }
for _, rt := range tests { for _, rt := range tests {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment