Merge pull request #51356 from wongma7/pv-cap-resize

Automatic merge from submit-queue (batch tested with PRs 51441, 51356, 51460) Don't update pvc.status.capacity if pvc is already Bound As discussed here https://github.com/kubernetes/community/pull/657#discussion_r128008128, in order for `pvc.status.Capacity < pv.Spec.Capcity` to be the mechanism for volume filesystem* resize, the pv controller should stop updating pvc.status.Capacity every resync period. /assign @jsafrane /sig storage ```release-note NONE ```

Merge pull request #51356 from wongma7/pv-cap-resize
520eab77 · Kubernetes Submit Queue · GitHub · 169de991 · 19ebaf28 · 520eab77
Commit 520eab77 authored Aug 28, 2017 by Kubernetes Submit Queue Committed by GitHub Aug 28, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 13 additions and 8 deletions

pv_controller.go pkg/controller/volume/persistentvolume/pv_controller.go +13 -8

No files found.
--- a/pkg/controller/volume/persistentvolume/pv_controller.go
+++ b/pkg/controller/volume/persistentvolume/pv_controller.go
@@ -626,14 +626,19 @@ func (ctrl *PersistentVolumeController) updateClaimStatus(claim *v1.PersistentVo
 			dirty = true
 		}

-		volumeCap, ok := volume.Spec.Capacity[v1.ResourceStorage]
-		if !ok {
-			return nil, fmt.Errorf("PersistentVolume %q is without a storage capacity", volume.Name)
-		}
-		claimCap, ok := claim.Status.Capacity[v1.ResourceStorage]
-		if !ok || volumeCap.Cmp(claimCap) != 0 {
-			claimClone.Status.Capacity = volume.Spec.Capacity
-			dirty = true
+		// Update Capacity if the claim is becoming Bound, not if it was already.
+		// A discrepancy can be intentional to mean that the PVC filesystem size
+		// doesn't match the PV block device size, so don't clobber it
+		if claim.Status.Phase != phase {
+			volumeCap, ok := volume.Spec.Capacity[v1.ResourceStorage]
+			if !ok {
+				return nil, fmt.Errorf("PersistentVolume %q is without a storage capacity", volume.Name)
+			}
+			claimCap, ok := claim.Status.Capacity[v1.ResourceStorage]
+			if !ok || volumeCap.Cmp(claimCap) != 0 {
+				claimClone.Status.Capacity = volume.Spec.Capacity
+				dirty = true
+			}
 		}
 	}