Merge pull request #37789 from yarntime/check_min_max

Automatic merge from submit-queue check the value of min and max in kubectl check the value of min and max in kubectl.

Merge pull request #37789 from yarntime/check_min_max
513893c9 · Kubernetes Submit Queue · GitHub · bc342006 · 4bbc3ba7 · 513893c9
Commit 513893c9 authored Dec 04, 2016 by Kubernetes Submit Queue Committed by GitHub Dec 04, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

autoscale.go pkg/kubectl/autoscale.go +5 -0

No files found.
--- a/pkg/kubectl/autoscale.go
+++ b/pkg/kubectl/autoscale.go
@@ -97,6 +97,11 @@ func generateHPA(genericParams map[string]interface{}) (runtime.Object, error) {
 	if err != nil {
 		return nil, err
 	}
+
+	if min > max {
+		return nil, fmt.Errorf("'max' must be greater than or equal to 'min'.")
+	}
+
 	cpuString, found := params["cpu-percent"]
 	cpu := -1
 	if found {