Merge pull request #75705 from oomichi/golint-e2e-framework-f

test/e2e/framework/flake_reporting_util.go

@@ -22,12 +22,14 @@ import (
 	"sync"
 )
 
+// FlakeReport is a struct for managing the flake report.
 type FlakeReport struct {
 	lock       sync.RWMutex
 	Flakes     []string `json:"flakes"`
 	FlakeCount int      `json:"flakeCount"`
 }
 
+// NewFlakeReport returns a new flake report.
 func NewFlakeReport() *FlakeReport {
 	return &FlakeReport{
 		Flakes: []string{},
@@ -62,12 +64,14 @@ func (f *FlakeReport) RecordFlakeIfError(err error, optionalDescription ...inter
 	f.FlakeCount++
 }
 
+// GetFlakeCount returns the flake count.
 func (f *FlakeReport) GetFlakeCount() int {
 	f.lock.RLock()
 	defer f.lock.RUnlock()
 	return f.FlakeCount
 }
 
+// PrintHumanReadable returns string of flake report.
 func (f *FlakeReport) PrintHumanReadable() string {
 	f.lock.RLock()
 	defer f.lock.RUnlock()
@@ -80,12 +84,14 @@ func (f *FlakeReport) PrintHumanReadable() string {
 	return buf.String()
 }
 
+// PrintJSON returns the summary of frake report with JSON format.
 func (f *FlakeReport) PrintJSON() string {
 	f.lock.RLock()
 	defer f.lock.RUnlock()
 	return PrettyPrintJSON(f)
 }
 
+// SummaryKind returns the summary of flake report.
 func (f *FlakeReport) SummaryKind() string {
 	return "FlakeReport"
 }

test/e2e/network/networking_perf.go

@@ -60,7 +60,7 @@ func networkingIPerfTest(isIPv6 bool) {
 		expectedBandwidth := int(float64(maxBandwidthBits) / float64(totalPods))
 		Expect(totalPods).NotTo(Equal(0))
 		appName := "iperf-e2e"
-		err, _ := f.CreateServiceForSimpleAppWithPods(
+		_, err := f.CreateServiceForSimpleAppWithPods(
 			8001,
 			8002,
 			appName,