Remove redundant tests. We already check that no changes have been made in…

pkg/runtime/conversion_generation_test.go

-/*
-Copyright 2015 The Kubernetes Authors All rights reserved.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package runtime_test
-
-import (
-	"bufio"
-	"bytes"
-	"fmt"
-	"io"
-	"io/ioutil"
-	"os"
-	"path"
-	"testing"
-
-	"k8s.io/kubernetes/pkg/api"
-	"k8s.io/kubernetes/pkg/api/testapi"
-	_ "k8s.io/kubernetes/pkg/api/v1"
-	"k8s.io/kubernetes/pkg/runtime"
-	"k8s.io/kubernetes/pkg/util"
-)
-
-func generateConversions(t *testing.T, version string) bytes.Buffer {
-	g := runtime.NewConversionGenerator(api.Scheme.Raw(), path.Join("k8s.io/kubernetes/pkg/api", version))
-	apiShort := g.AddImport("k8s.io/kubernetes/pkg/api")
-	g.AddImport("k8s.io/kubernetes/pkg/api/resource")
-	// TODO(wojtek-t): Change the overwrites to a flag.
-	g.OverwritePackage(version, "")
-	for _, knownType := range api.Scheme.KnownTypes(version) {
-		if err := g.GenerateConversionsForType(version, knownType); err != nil {
-			t.Fatalf("error while generating conversion functions for %v: %v", knownType, err)
-		}
-	}
-	g.RepackImports(util.NewStringSet())
-	var functions bytes.Buffer
-	functionsWriter := bufio.NewWriter(&functions)
-	if err := g.WriteImports(functionsWriter); err != nil {
-		t.Fatalf("error while writing imports: %v", err)
-	}
-	if err := g.WriteConversionFunctions(functionsWriter); err != nil {
-		t.Fatalf("couldn't generate conversion functions: %v", err)
-	}
-	if err := g.RegisterConversionFunctions(functionsWriter, fmt.Sprintf("%s.Scheme", apiShort)); err != nil {
-		t.Fatalf("couldn't generate conversion function names: %v", err)
-	}
-	if err := functionsWriter.Flush(); err != nil {
-		t.Fatalf("error while flushing writer")
-	}
-
-	return functions
-}
-
-func readLinesUntil(t *testing.T, reader *bufio.Reader, stop string, buffer *bytes.Buffer) error {
-	for {
-		line, err := reader.ReadString('\n')
-		if err == io.EOF {
-			return fmt.Errorf("'%s' line not found", stop)
-		}
-		if err != nil {
-			t.Fatalf("error while reading file: %v", err)
-		}
-		if line == stop {
-			break
-		}
-		if buffer != nil {
-			if _, err := buffer.WriteString(line); err != nil {
-				t.Fatalf("error while buffering line")
-			}
-		}
-	}
-	return nil
-}
-
-func bufferExistingGeneratedCode(t *testing.T, fileName string) bytes.Buffer {
-	file, err := os.Open(fileName)
-	if err != nil {
-		t.Fatalf("couldn't open file %s", fileName)
-	}
-	defer file.Close()
-
-	reader := bufio.NewReader(file)
-
-	functionsPrefix := "// AUTO-GENERATED FUNCTIONS START HERE\n"
-	functionsSuffix := "// AUTO-GENERATED FUNCTIONS END HERE\n"
-	if err := readLinesUntil(t, reader, functionsPrefix, nil); err != nil {
-		t.Fatalf("error while parsing file: %v", err)
-	}
-	var functions bytes.Buffer
-	if err := readLinesUntil(t, reader, functionsSuffix, &functions); err != nil {
-		t.Fatalf("error while parsing file: %v", err)
-	}
-	_, err = reader.ReadString('\n')
-	if err == nil || err != io.EOF {
-		t.Fatalf("end-of-file expected")
-	}
-	return functions
-}
-
-func compareBuffers(t *testing.T, generatedFile string, existing, generated bytes.Buffer) bool {
-	ok := true
-	for {
-		existingLine, existingErr := existing.ReadString('\n')
-		generatedLine, generatedErr := generated.ReadString('\n')
-		if existingErr == io.EOF && generatedErr == io.EOF {
-			break
-		}
-		if existingErr != generatedErr {
-			ok = false
-			t.Errorf("reading errors: existing %v generated %v", existingErr, generatedErr)
-			return ok
-		}
-		if existingErr != nil {
-			ok = false
-			t.Errorf("error while reading: %v", existingErr)
-		}
-		if existingLine != generatedLine {
-			ok = false
-			diff := fmt.Sprintf("\nexpected: %s\n     got: %s", generatedLine, existingLine)
-			t.Errorf("please update conversion functions; generated: %s; first diff: %s", generatedFile, diff)
-			return ok
-		}
-	}
-	return ok
-}
-
-func TestNoManualChangesToGenerateConversions(t *testing.T) {
-	version := testapi.Version()
-	fileName := fmt.Sprintf("../../pkg/api/%s/conversion_generated.go", version)
-
-	existingFunctions := bufferExistingGeneratedCode(t, fileName)
-	generatedFunctions := generateConversions(t, version)
-
-	functionsTxt := fmt.Sprintf("%s.functions.txt", version)
-	ioutil.WriteFile(functionsTxt, generatedFunctions.Bytes(), os.FileMode(0644))
-
-	if ok := compareBuffers(t, functionsTxt, existingFunctions, generatedFunctions); ok {
-		os.Remove(functionsTxt)
-	}
-}

pkg/runtime/deep_copy_generation_test.go

-/*
-Copyright 2015 The Kubernetes Authors All rights reserved.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package runtime_test
-
-import (
-	"bufio"
-	"bytes"
-	"fmt"
-	"io/ioutil"
-	"os"
-	"path"
-	"testing"
-
-	"k8s.io/kubernetes/pkg/api"
-	"k8s.io/kubernetes/pkg/api/testapi"
-	_ "k8s.io/kubernetes/pkg/api/v1"
-	"k8s.io/kubernetes/pkg/runtime"
-	"k8s.io/kubernetes/pkg/util"
-
-	"github.com/golang/glog"
-)
-
-func generateDeepCopies(t *testing.T, version string) bytes.Buffer {
-	testedVersion := version
-	registerTo := "api.Scheme"
-	if testedVersion == "api" {
-		testedVersion = api.Scheme.Raw().InternalVersion
-		registerTo = "Scheme"
-	}
-
-	g := runtime.NewDeepCopyGenerator(api.Scheme.Raw(), path.Join("k8s.io/kubernetes/pkg/api", testedVersion), util.NewStringSet("k8s.io/kubernetes"))
-	g.AddImport("k8s.io/kubernetes/pkg/api")
-	g.OverwritePackage(version, "")
-
-	for _, knownType := range api.Scheme.KnownTypes(testedVersion) {
-		if err := g.AddType(knownType); err != nil {
-			glog.Errorf("error while generating deep-copy functions for %v: %v", knownType, err)
-		}
-	}
-
-	var functions bytes.Buffer
-	functionsWriter := bufio.NewWriter(&functions)
-	g.RepackImports()
-	if err := g.WriteImports(functionsWriter); err != nil {
-		t.Fatalf("couldn't generate deep-copy function imports: %v", err)
-	}
-	if err := g.WriteDeepCopyFunctions(functionsWriter); err != nil {
-		t.Fatalf("couldn't generate deep-copy functions: %v", err)
-	}
-	if err := g.RegisterDeepCopyFunctions(functionsWriter, registerTo); err != nil {
-		t.Fatalf("couldn't generate deep-copy function names: %v", err)
-	}
-	if err := functionsWriter.Flush(); err != nil {
-		t.Fatalf("error while flushing writer")
-	}
-
-	return functions
-}
-
-func TestNoManualChangesToGenerateDeepCopies(t *testing.T) {
-	versions := []string{"api", testapi.Version()}
-
-	for _, version := range versions {
-		fileName := ""
-		if version == "api" {
-			fileName = "../../pkg/api/deep_copy_generated.go"
-		} else {
-			fileName = fmt.Sprintf("../../pkg/api/%s/deep_copy_generated.go", version)
-		}
-
-		existingFunctions := bufferExistingGeneratedCode(t, fileName)
-		generatedFunctions := generateDeepCopies(t, version)
-
-		functionsTxt := fmt.Sprintf("%s.deep_copy.txt", version)
-		ioutil.WriteFile(functionsTxt, generatedFunctions.Bytes(), os.FileMode(0644))
-
-		if ok := compareBuffers(t, functionsTxt, existingFunctions, generatedFunctions); ok {
-			os.Remove(functionsTxt)
-		}
-	}
-}