Fix flake associated with time out volumes

This test is suspectible to flakes because sometimes while we verify if volume is attached to a node, reconciler loop can turn second time and it can confirm the volume as attached.

Fix flake associated with time out volumes
4d481a0f · Hemant Kumar · b5336132 · 4d481a0f
Commit 4d481a0f authored May 23, 2019 by Hemant Kumar
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

testing.go pkg/volume/testing/testing.go +5 -0

No files found.
--- a/pkg/volume/testing/testing.go
+++ b/pkg/volume/testing/testing.go
@@ -907,6 +907,11 @@ func (fv *FakeVolume) Attach(spec *Spec, nodeName types.NodeName) (string, error
 		if nodeName == UncertainAttachNode {
 			return "/dev/vdb-test", nil
 		}
+		// even if volume was previously attached to time out, we need to keep returning error
+		// so as reconciler can not confirm this volume as attached.
+		if nodeName == TimeoutAttachNode {
+			return "", fmt.Errorf("Timed out to attach volume %q to node %q", volumeName, nodeName)
+		}
 		if volumeNode == nodeName || volumeNode == MultiAttachNode || nodeName == MultiAttachNode {
 			return "/dev/vdb-test", nil
 		}