Unverified Commit 4d380ee2 authored by Kubernetes Prow Robot's avatar Kubernetes Prow Robot Committed by GitHub

Merge pull request #76117 from SataQiu/fix-golint-test-20190404

Fix some golint failures of e2e_kubeadm/bootstrap_signer.go e2e_kubeadm/framework.go
parents 79a8827c e6b9197f
...@@ -19,7 +19,7 @@ package e2e_kubeadm ...@@ -19,7 +19,7 @@ package e2e_kubeadm
import ( import (
"k8s.io/kubernetes/test/e2e/framework" "k8s.io/kubernetes/test/e2e/framework"
. "github.com/onsi/ginkgo" "github.com/onsi/ginkgo"
) )
const ( const (
...@@ -37,7 +37,7 @@ var _ = KubeadmDescribe("bootstrap signer", func() { ...@@ -37,7 +37,7 @@ var _ = KubeadmDescribe("bootstrap signer", func() {
// so we are disabling the creation of a namespace in order to get a faster execution // so we are disabling the creation of a namespace in order to get a faster execution
f.SkipNamespaceCreation = true f.SkipNamespaceCreation = true
It("should be active", func() { ginkgo.It("should be active", func() {
//NB. this is technically implemented a part of the control-plane phase //NB. this is technically implemented a part of the control-plane phase
// and more specifically if the controller manager is properly configured, // and more specifically if the controller manager is properly configured,
// the bootstrapsigner controller is activated and the system:controller:bootstrap-signer // the bootstrapsigner controller is activated and the system:controller:bootstrap-signer
......
...@@ -18,6 +18,7 @@ package e2e_kubeadm ...@@ -18,6 +18,7 @@ package e2e_kubeadm
import "k8s.io/kubernetes/test/e2e/framework" import "k8s.io/kubernetes/test/e2e/framework"
// KubeadmDescribe annotates the test with the Kubeadm label.
func KubeadmDescribe(text string, body func()) bool { func KubeadmDescribe(text string, body func()) bool {
return framework.KubeDescribe("[sig-cluster-lifecycle] [area-kubeadm] "+text, body) return framework.KubeDescribe("[sig-cluster-lifecycle] [area-kubeadm] "+text, body)
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment