Merge pull request #53531 from leblancd/local_prov_no_logs

Automatic merge from submit-queue (batch tested with PRs 53350, 52688, 53531, 52515). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Skip e2e check for logs API path if provider is skeleton There is a networking e2e test with the It() description: ``` "should provide unchanging, static URL paths for kubernetes api services" ``` This test performs GETs from the Kubernetes API using various paths, including "/logs". This test for a GET using path "/logs" should be skipped for provider type "skeleton", since this path is unsupported. This change adds "skeleton" to the list of providers for which this test case should be skipped. fixes #53529 **What this PR does / why we need it**: This change adds "skeleton" to the list of providers for which the test for an API GET using the "/logs" path should be skipped. This is needed because, as far as I can tell, the "skeleton" provider doesn't support the "/logs" api path. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #53529 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

Merge pull request #53531 from leblancd/local_prov_no_logs
4ba54c95 · Kubernetes Submit Queue · GitHub · edd6c8e4 · 9d448494 · 4ba54c95
Commit 4ba54c95 authored Oct 06, 2017 by Kubernetes Submit Queue Committed by GitHub Oct 06, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

networking.go test/e2e/network/networking.go +1 -1

No files found.
--- a/test/e2e/network/networking.go
+++ b/test/e2e/network/networking.go
@@ -70,7 +70,7 @@ var _ = SIGDescribe("Networking", func() {
 			{path: "/version"},
 			// TODO: test proxy links here
 		}
-		if !framework.ProviderIs("gke") {
+		if !framework.ProviderIs("gke", "skeleton") {
 			tests = append(tests, struct{ path string }{path: "/logs"})
 		}
 		for _, test := range tests {