Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
48d788de
Unverified
Commit
48d788de
authored
Nov 13, 2018
by
k8s-ci-robot
Committed by
GitHub
Nov 13, 2018
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #71001 from Deepomatic/recognize_docker_1809_version
Recognize newer docker versions without -ce/-ee suffix: 18.09.0
parents
bc6aee19
068cdaa5
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
1 deletion
+6
-1
docker_validator.go
cmd/kubeadm/app/util/system/docker_validator.go
+1
-1
docker_validator_test.go
cmd/kubeadm/app/util/system/docker_validator_test.go
+5
-0
No files found.
cmd/kubeadm/app/util/system/docker_validator.go
View file @
48d788de
...
...
@@ -73,7 +73,7 @@ func (d *DockerValidator) validateDockerInfo(spec *DockerSpec, info types.Info)
if
!
matched
{
// If it's of the new Docker version scheme but didn't match above, it
// must be a newer version than the most recently validated one.
ver
:=
`\d{2}\.\d+\.\d+
-[a-z]{2}
`
ver
:=
`\d{2}\.\d+\.\d+
(?:-[a-z]{2})?
`
r
:=
regexp
.
MustCompile
(
ver
)
if
r
.
MatchString
(
info
.
ServerVersion
)
{
d
.
Reporter
.
Report
(
dockerConfigPrefix
+
"VERSION"
,
info
.
ServerVersion
,
good
)
...
...
cmd/kubeadm/app/util/system/docker_validator_test.go
View file @
48d788de
...
...
@@ -81,6 +81,11 @@ func TestValidateDockerInfo(t *testing.T) {
err
:
false
,
warn
:
false
,
},
{
info
:
types
.
Info
{
Driver
:
"driver_2"
,
ServerVersion
:
"18.09.0"
},
err
:
false
,
warn
:
true
,
},
}
{
warn
,
err
:=
v
.
validateDockerInfo
(
spec
,
test
.
info
)
if
!
test
.
err
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment