Unverified Commit 3bc595e3 authored by Kubernetes Prow Robot's avatar Kubernetes Prow Robot Committed by GitHub

Merge pull request #77722 from andyzhangx/fix-incorrect-metrics

fix incorrect prometheus azure metrics
parents f5a1ceb1 a33b86e2
...@@ -50,12 +50,14 @@ func newMetricContext(prefix, request, resourceGroup, subscriptionID string) *me ...@@ -50,12 +50,14 @@ func newMetricContext(prefix, request, resourceGroup, subscriptionID string) *me
} }
} }
func (mc *metricContext) Observe(err error) { func (mc *metricContext) Observe(err error) error {
apiMetrics.latency.WithLabelValues(mc.attributes...).Observe( apiMetrics.latency.WithLabelValues(mc.attributes...).Observe(
time.Since(mc.start).Seconds()) time.Since(mc.start).Seconds())
if err != nil { if err != nil {
apiMetrics.errors.WithLabelValues(mc.attributes...).Inc() apiMetrics.errors.WithLabelValues(mc.attributes...).Inc()
} }
return err
} }
func registerAPIMetrics(attributes ...string) *apiCallMetrics { func registerAPIMetrics(attributes ...string) *apiCallMetrics {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment