Changed the keepChannel to buffered channel.

Since the keepChannel is used to send data, not just for synchronizaiton, so make it a buffered channel can avoid unnecessary goroutine yields.

Changed the keepChannel to buffered channel.
3a955722 · Yifan Gu · e48d85a4 · 3a955722
Commit 3a955722 authored Jul 14, 2014 by Yifan Gu
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

kubelet.go pkg/kubelet/kubelet.go +3 -1

No files found.
--- a/pkg/kubelet/kubelet.go
+++ b/pkg/kubelet/kubelet.go
@@ -44,6 +44,8 @@ import (
 	"gopkg.in/v1/yaml"
 )

+const defaultChanSize = 1024
+
 // DockerContainerData is the structured representation of the JSON object returned by Docker inspect
 type DockerContainerData struct {
 	state struct {
@@ -758,7 +760,7 @@ func (kl *Kubelet) SyncManifests(config []api.ContainerManifest) error {
 	glog.Infof("Desired: %+v", config)
 	var err error
 	dockerIdsToKeep := map[DockerID]empty{}
-	keepChannel := make(chan DockerID)
+	keepChannel := make(chan DockerID, defaultChanSize)
 	waitGroup := sync.WaitGroup{}

 	// Check for any containers that need starting