Skip to content

K
k3s
Commit 3a456bf9 authored by Jonathan Basseri's avatar Jonathan Basseri
Browse files
Options

Set a minimum b.N for scheduler_perf benchmarks.

Under the default behavior of Go benchmark tests, all our scheduler_perf benchmark tests run with b.N=1, which is lower than we would like. This adds a lower bound to b.N so that the results are more meaningful. The alternative to this change is to always run these tests with the -benchtime flag set to a duration which will force b.N to increase. That would cause any test setup to be executed repeatedly as b.N ramps up, and -timout would probably also need to be set higher.
parent 2f1408eb
Hide whitespace changes
Inline Side-by-side
Showing with 12 additions and 9 deletions
test/integration/scheduler_perf/scheduler_bench_test.go
View file @ 3a456bf9
...@@ -31,22 +31,25 @@ import ( ...@@ -31,22 +31,25 @@ import (
// BenchmarkScheduling benchmarks the scheduling rate when the cluster has // BenchmarkScheduling benchmarks the scheduling rate when the cluster has
// various quantities of nodes and scheduled pods. // various quantities of nodes and scheduled pods.
func BenchmarkScheduling(b *testing.B) { func BenchmarkScheduling(b *testing.B) {
tests := []struct{ nodes, pods int }{ tests := []struct{ nodes, pods, minOps int }{
{nodes: 100, pods: 0}, {nodes: 100, pods: 0, minOps: 100},
{nodes: 100, pods: 1000}, {nodes: 100, pods: 1000, minOps: 100},
{nodes: 1000, pods: 0}, {nodes: 1000, pods: 0, minOps: 100},
{nodes: 1000, pods: 1000}, {nodes: 1000, pods: 1000, minOps: 100},
} }
for _, test := range tests { for _, test := range tests {
name := fmt.Sprintf("%vNodes/%vPods", test.nodes, test.pods) name := fmt.Sprintf("%vNodes/%vPods", test.nodes, test.pods)
b.Run(name, func(b *testing.B) { benchmarkScheduling(test.nodes, test.pods, b) }) b.Run(name, func(b *testing.B) { benchmarkScheduling(test.nodes, test.pods, test.minOps, b) })
} }
} }
// benchmarkScheduling benchmarks scheduling rate with specific number of nodes // benchmarkScheduling benchmarks scheduling rate with specific number of nodes
// and specific number of pods already scheduled. Since an operation takes relatively // and specific number of pods already scheduled.
// long time, b.N should be small: 10 - 100. // Since an operation typically takes more than 1 second, we put a minimum bound on b.N of minOps.
func benchmarkScheduling(numNodes, numScheduledPods int, b *testing.B) { func benchmarkScheduling(numNodes, numScheduledPods, minOps int, b *testing.B) {
if b.N < minOps {
b.N = minOps
}
schedulerConfigFactory, finalFunc := mustSetupScheduler() schedulerConfigFactory, finalFunc := mustSetupScheduler()
defer finalFunc() defer finalFunc()
c := schedulerConfigFactory.GetClient() c := schedulerConfigFactory.GetClient()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment