Merge pull request #67315 from mortent/FixFlakeDaemonsetTest

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix flakiness in daemonset TestLaunchWithHashCollisiion **What this PR does / why we need it**: Addresses flakiness in test/integration/daemonset TestLaunchWithHashCollision. It makes sure the test waits for the pod to be added to the daemonset before updating the daemonset. The should avoid the race where the daemonset gets updated in between the calls to get and update in the test. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #67273 **Special notes for your reviewer**: @janetkuo **Release note**: ```release-note NONE ```

Merge pull request #67315 from mortent/FixFlakeDaemonsetTest
3956bba3 · Kubernetes Submit Queue · GitHub · cd786bda · d6ffcae3 · 3956bba3
Unverified Commit 3956bba3 authored Aug 14, 2018 by Kubernetes Submit Queue Committed by GitHub Aug 14, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 22 additions and 5 deletions

BUILD test/integration/daemonset/BUILD +1 -0

daemonset_test.go test/integration/daemonset/daemonset_test.go +21 -5

No files found.
--- a/test/integration/daemonset/BUILD
+++ b/test/integration/daemonset/BUILD
@@ -41,6 +41,7 @@ go_test(
        "//staging/src/k8s.io/client-go/rest:go_default_library",
        "//staging/src/k8s.io/client-go/tools/cache:go_default_library",
        "//staging/src/k8s.io/client-go/tools/record:go_default_library",
+        "//staging/src/k8s.io/client-go/util/retry:go_default_library",
        "//test/integration/framework:go_default_library",
    ],
 )

--- a/test/integration/daemonset/daemonset_test.go
+++ b/test/integration/daemonset/daemonset_test.go
@@ -51,6 +51,7 @@ import (
 	"k8s.io/kubernetes/pkg/scheduler/factory"
 	labelsutil "k8s.io/kubernetes/pkg/util/labels"
 	"k8s.io/kubernetes/pkg/util/metrics"
+	"k8s.io/kubernetes/staging/src/k8s.io/client-go/util/retry"
 	"k8s.io/kubernetes/test/integration/framework"
 )
@@ -461,6 +462,22 @@ func validateFailedPlacementEvent(eventClient corev1typed.EventInterface, t *tes
 	}
 }
+func updateDS(t *testing.T, dsClient appstyped.DaemonSetInterface, dsName string, updateFunc func(*apps.DaemonSet)) *apps.DaemonSet {
+	var ds *apps.DaemonSet
+	if err := retry.RetryOnConflict(retry.DefaultBackoff, func() error {
+		newDS, err := dsClient.Get(dsName, metav1.GetOptions{})
+		if err != nil {
+			return err
+		}
+		updateFunc(newDS)
+		ds, err = dsClient.Update(newDS)
+		return err
+	}); err != nil {
+		t.Fatalf("Failed to update DaemonSet: %v", err)
+	}
+	return ds
+}
 func forEachFeatureGate(t *testing.T, tf func(t *testing.T)) {
 	for _, fg := range featureGates() {
 		func() {
@@ -832,7 +849,7 @@ func TestLaunchWithHashCollision(t *testing.T) {
 	// Wait for the DaemonSet to be created before proceeding
 	err = waitForDaemonSetAndControllerRevisionCreated(clientset, ds.Name, ds.Namespace)
 	if err != nil {
-		t.Fatalf("Failed to create DeamonSet: %v", err)
+		t.Fatalf("Failed to create DaemonSet: %v", err)
 	}
 	ds, err = dsClient.Get(ds.Name, metav1.GetOptions{})
@@ -875,10 +892,9 @@ func TestLaunchWithHashCollision(t *testing.T) {
 	// Make an update of the DaemonSet which we know will create a hash collision when
 	// the next ControllerRevision is created.
-	_, err = dsClient.Update(ds)
+	ds = updateDS(t, dsClient, ds.Name, func(updateDS *apps.DaemonSet) {
-	if err != nil {
+		updateDS.Spec.Template.Spec.TerminationGracePeriodSeconds = &one
-		t.Fatalf("Failed to update DaemonSet: %v", err)
+	})
-	}
 	// Wait for any pod with the latest Spec to exist
 	err = wait.PollImmediate(100*time.Millisecond, 10*time.Second, func() (bool, error) {