Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
392bf0ad
Unverified
Commit
392bf0ad
authored
Jun 29, 2018
by
Abhishek Kumar Singh
Committed by
GitHub
Jun 29, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Typo Fix.
Fixed minor spelling mistakes caught while reading `cronjob_controller.go` source code reference at [operating-kubernetes](
https://stripe.com/blog/operating-kubernetes
)
parent
a883243c
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
cronjob_controller.go
pkg/controller/cronjob/cronjob_controller.go
+4
-4
No files found.
pkg/controller/cronjob/cronjob_controller.go
View file @
392bf0ad
...
@@ -20,7 +20,7 @@ package cronjob
...
@@ -20,7 +20,7 @@ package cronjob
I did not use watch or expectations. Those add a lot of corner cases, and we aren't
I did not use watch or expectations. Those add a lot of corner cases, and we aren't
expecting a large volume of jobs or scheduledJobs. (We are favoring correctness
expecting a large volume of jobs or scheduledJobs. (We are favoring correctness
over scalability. If we find a single controller thread is too slow because
over scalability. If we find a single controller thread is too slow because
there are a lot of Jobs or CronJobs, we
we
can parallelize by Namespace.
there are a lot of Jobs or CronJobs, we can parallelize by Namespace.
If we find the load on the API server is too high, we can use a watch and
If we find the load on the API server is too high, we can use a watch and
UndeltaStore.)
UndeltaStore.)
...
@@ -329,7 +329,7 @@ func syncOne(sj *batchv1beta1.CronJob, js []batchv1.Job, now time.Time, jc jobCo
...
@@ -329,7 +329,7 @@ func syncOne(sj *batchv1beta1.CronJob, js []batchv1.Job, now time.Time, jc jobCo
// If this process restarts at this point (after posting a job, but
// If this process restarts at this point (after posting a job, but
// before updating the status), then we might try to start the job on
// before updating the status), then we might try to start the job on
// the next time. Actually, if we relist the SJs and Jobs on the next
// the next time. Actually, if we re
-
list the SJs and Jobs on the next
// iteration of syncAll, we might not see our own status update, and
// iteration of syncAll, we might not see our own status update, and
// then post one again. So, we need to use the job name as a lock to
// then post one again. So, we need to use the job name as a lock to
// prevent us from making the job twice (name the job with hash of its
// prevent us from making the job twice (name the job with hash of its
...
@@ -350,11 +350,11 @@ func syncOne(sj *batchv1beta1.CronJob, js []batchv1.Job, now time.Time, jc jobCo
...
@@ -350,11 +350,11 @@ func syncOne(sj *batchv1beta1.CronJob, js []batchv1.Job, now time.Time, jc jobCo
return
return
}
}
// deleteJob reaps a job, deleting the job, the po
b
s and the reference in the active list
// deleteJob reaps a job, deleting the job, the po
d
s and the reference in the active list
func
deleteJob
(
sj
*
batchv1beta1
.
CronJob
,
job
*
batchv1
.
Job
,
jc
jobControlInterface
,
func
deleteJob
(
sj
*
batchv1beta1
.
CronJob
,
job
*
batchv1
.
Job
,
jc
jobControlInterface
,
pc
podControlInterface
,
recorder
record
.
EventRecorder
,
reason
string
)
bool
{
pc
podControlInterface
,
recorder
record
.
EventRecorder
,
reason
string
)
bool
{
// TODO: this should be replaced with server side job deletion
// TODO: this should be replaced with server side job deletion
// curren
continue
tly this mimics JobReaper from pkg/kubectl/stop.go
// currently this mimics JobReaper from pkg/kubectl/stop.go
nameForLog
:=
fmt
.
Sprintf
(
"%s/%s"
,
sj
.
Namespace
,
sj
.
Name
)
nameForLog
:=
fmt
.
Sprintf
(
"%s/%s"
,
sj
.
Namespace
,
sj
.
Name
)
// scale job down to 0
// scale job down to 0
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment