Commit 3892f669 authored by fansong.cfs's avatar fansong.cfs

fix data race in unittest

parent a1588cfe
...@@ -25,7 +25,7 @@ import ( ...@@ -25,7 +25,7 @@ import (
"testing" "testing"
"time" "time"
"k8s.io/api/core/v1" v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/meta" "k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/fields" "k8s.io/apimachinery/pkg/fields"
...@@ -678,12 +678,16 @@ func TestDispatchingBookmarkEventsWithConcurrentStop(t *testing.T) { ...@@ -678,12 +678,16 @@ func TestDispatchingBookmarkEventsWithConcurrentStop(t *testing.T) {
t.Fatalf("failure to update version of object (%d) %#v", bookmark.ResourceVersion, bookmark.Object) t.Fatalf("failure to update version of object (%d) %#v", bookmark.ResourceVersion, bookmark.Object)
} }
wg := sync.WaitGroup{}
wg.Add(2)
go func() { go func() {
cacher.dispatchEvent(bookmark) cacher.dispatchEvent(bookmark)
wg.Done()
}() }()
go func() { go func() {
w.Stop() w.Stop()
wg.Done()
}() }()
done := make(chan struct{}) done := make(chan struct{})
...@@ -700,5 +704,6 @@ func TestDispatchingBookmarkEventsWithConcurrentStop(t *testing.T) { ...@@ -700,5 +704,6 @@ func TestDispatchingBookmarkEventsWithConcurrentStop(t *testing.T) {
t.Fatal("receive result timeout") t.Fatal("receive result timeout")
} }
w.Stop() w.Stop()
wg.Wait()
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment