GKE also requires SAR endpoints

There was a specific error flow that was commented as only applying to GKE. This was never tested specifically for GKE (only commented as such) but that seems to be out of date and can be removed. If the SAR endpoint does not exist it should be considered an error.

GKE also requires SAR endpoints
3853a0ec · John Schnake · d2ce69d9 · 3853a0ec · 3853a0ec
Commit 3853a0ec authored May 02, 2019 by John Schnake
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 11 deletions

BUILD test/e2e/framework/auth/BUILD +0 -1

helpers.go test/e2e/framework/auth/helpers.go +0 -10

No files found.
--- a/test/e2e/framework/auth/BUILD
+++ b/test/e2e/framework/auth/BUILD
@@ -8,7 +8,6 @@ go_library(
    deps = [
        "//staging/src/k8s.io/api/authorization/v1beta1:go_default_library",
        "//staging/src/k8s.io/api/rbac/v1beta1:go_default_library",
-        "//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",
        "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
        "//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library",
        "//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",

--- a/test/e2e/framework/auth/helpers.go
+++ b/test/e2e/framework/auth/helpers.go
@@ -25,7 +25,6 @@ import (
 	"github.com/pkg/errors"
 	authorizationv1beta1 "k8s.io/api/authorization/v1beta1"
 	rbacv1beta1 "k8s.io/api/rbac/v1beta1"
-	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/apimachinery/pkg/util/wait"
@@ -68,15 +67,6 @@ func WaitForNamedAuthorizationUpdate(c v1beta1authorization.SubjectAccessReviews

 	err := wait.Poll(policyCachePollInterval, policyCachePollTimeout, func() (bool, error) {
 		response, err := c.SubjectAccessReviews().Create(review)
-		// GKE doesn't enable the SAR endpoint.  Without this endpoint, we cannot determine if the policy engine
-		// has adjusted as expected.  In this case, simply wait one second and hope it's up to date
-		// TODO: Should have a check for the provider here but that introduces too tight of
-		// coupling with the `framework` package. See: https://github.com/kubernetes/kubernetes/issues/76726
-		if apierrors.IsNotFound(err) {
-			logf("SubjectAccessReview endpoint is missing")
-			time.Sleep(1 * time.Second)
-			return true, nil
-		}
 		if err != nil {
 			return false, err
 		}