Unverified Commit 34d767d4 authored by Brian Downs's avatar Brian Downs Committed by GitHub

Merge pull request #3510 from briandowns/backport_issue-3414_release_1.21

[Backport 1.21] - fix possible race where bootstrap data might not save
parents 5a67e8dc 3224f6b5
...@@ -3,6 +3,7 @@ package cluster ...@@ -3,6 +3,7 @@ package cluster
import ( import (
"context" "context"
"net/url" "net/url"
"runtime"
"strings" "strings"
"github.com/k3s-io/kine/pkg/endpoint" "github.com/k3s-io/kine/pkg/endpoint"
...@@ -102,15 +103,22 @@ func (c *Cluster) Start(ctx context.Context) (<-chan struct{}, error) { ...@@ -102,15 +103,22 @@ func (c *Cluster) Start(ctx context.Context) (<-chan struct{}, error) {
// snapshots will be empty. // snapshots will be empty.
if c.managedDB != nil { if c.managedDB != nil {
go func() { go func() {
for range ready { for {
if err := c.save(ctx); err != nil { select {
panic(err) case <-ready:
if err := c.save(ctx); err != nil {
panic(err)
}
if err := c.managedDB.StoreSnapshotData(ctx); err != nil {
logrus.Errorf("Failed to record snapshots for cluster: %v", err)
}
return
default:
runtime.Gosched()
} }
} }
if err := c.managedDB.StoreSnapshotData(ctx); err != nil {
logrus.Errorf("Failed to record snapshots for cluster: %v", err)
}
}() }()
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment