Merge pull request #54248 from MrHohn/gcp-ilb-skip-large-cluster

Automatic merge from submit-queue (batch tested with PRs 52794, 54243, 54248, 53491, 53841). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Skip ILB e2e test on GCP if cluster size exceeds limit **What this PR does / why we need it**: Ack https://github.com/kubernetes/kubernetes/issues/52495#issuecomment-337293615, ILB test will fail on large cluster. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: xref https://github.com/kubernetes/kubernetes/issues/52495 **Special notes for your reviewer**: /assign @nicksardo @bowei cc @shyamjvs **Release note**: ```release-note NONE ```

Merge pull request #54248 from MrHohn/gcp-ilb-skip-large-cluster
34d5f40d · Kubernetes Submit Queue · GitHub · 84bad0e0 · 8f216be8 · 34d5f40d
Commit 34d5f40d authored Oct 19, 2017 by Kubernetes Submit Queue Committed by GitHub Oct 19, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 0 deletions

service_util.go test/e2e/framework/service_util.go +4 -0

service.go test/e2e/network/service.go +7 -0

No files found.
--- a/test/e2e/framework/service_util.go
+++ b/test/e2e/framework/service_util.go
@@ -89,6 +89,10 @@ const (

 	// ServiceTestTimeout is used for most polling/waiting activities
 	ServiceTestTimeout = 60 * time.Second
+
+	// GCPMaxInstancesInInstanceGroup is the maximum number of instances supported in
+	// one instance group on GCP.
+	GCPMaxInstancesInInstanceGroup = 2000
 )

 // This should match whatever the default/configured range is

--- a/test/e2e/network/service.go
+++ b/test/e2e/network/service.go
@@ -1339,8 +1339,15 @@ var _ = SIGDescribe("Services", func() {

 	It("should be able to create an internal type load balancer [Slow]", func() {
 		framework.SkipUnlessProviderIs("azure", "gke", "gce")
+		if framework.ProviderIs("gke", "gce") {
+			framework.SkipUnlessNodeCountIsAtMost(framework.GCPMaxInstancesInInstanceGroup)
+		}

 		createTimeout := framework.LoadBalancerCreateTimeoutDefault
+		if nodes := framework.GetReadySchedulableNodesOrDie(cs); len(nodes.Items) > framework.LargeClusterMinNodesNumber {
+			createTimeout = framework.LoadBalancerCreateTimeoutLarge
+		}
+
 		pollInterval := framework.Poll * 10

 		namespace := f.Namespace.Name