Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
344b42f0
Unverified
Commit
344b42f0
authored
Nov 10, 2018
by
k8s-ci-robot
Committed by
GitHub
Nov 10, 2018
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #70891 from mkimuram/issue/70760
Make csi alpha failing test skip
parents
7872a1db
f98b87ca
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
0 deletions
+18
-0
base.go
test/e2e/storage/testsuites/base.go
+13
-0
volumemode.go
test/e2e/storage/testsuites/volumemode.go
+5
-0
No files found.
test/e2e/storage/testsuites/base.go
View file @
344b42f0
...
...
@@ -18,6 +18,7 @@ package testsuites
import
(
"fmt"
"strings"
"time"
.
"github.com/onsi/ginkgo"
...
...
@@ -324,3 +325,15 @@ func deleteStorageClass(cs clientset.Interface, className string) {
Expect
(
err
)
.
NotTo
(
HaveOccurred
())
}
}
func
skipTestUntilBugfix
(
issueID
string
,
driverName
string
,
prefixes
[]
string
)
{
var
needSkip
bool
for
_
,
prefix
:=
range
prefixes
{
if
strings
.
HasPrefix
(
driverName
,
prefix
)
{
needSkip
=
true
}
}
if
needSkip
{
framework
.
Skipf
(
"Due to issue #%s, this test with %s doesn't pass, skipping until it fixes"
,
issueID
,
driverName
)
}
}
test/e2e/storage/testsuites/volumemode.go
View file @
344b42f0
...
...
@@ -76,6 +76,7 @@ func createVolumeModeTestInput(pattern testpatterns.TestPattern, resource volume
sc
:
resource
.
sc
,
pvc
:
resource
.
pvc
,
pv
:
resource
.
pv
,
driverName
:
dInfo
.
Name
,
testVolType
:
pattern
.
VolType
,
nodeName
:
dInfo
.
Config
.
ClientNodeName
,
volMode
:
pattern
.
VolMode
,
...
...
@@ -233,6 +234,7 @@ type volumeModeTestInput struct {
sc
*
storagev1
.
StorageClass
pvc
*
v1
.
PersistentVolumeClaim
pv
*
v1
.
PersistentVolume
driverName
string
testVolType
testpatterns
.
TestVolType
nodeName
string
volMode
v1
.
PersistentVolumeMode
...
...
@@ -339,6 +341,9 @@ func testVolumeModeSuccessForDynamicPV(input *volumeModeTestInput) {
ns
:=
f
.
Namespace
var
err
error
// TODO: This skip should be removed once #70760 is fixed
skipTestUntilBugfix
(
"70760"
,
input
.
driverName
,
[]
string
{
"csi-hostpath"
,
"com.google.csi.gcepd"
})
By
(
"Creating sc"
)
input
.
sc
,
err
=
cs
.
StorageV1
()
.
StorageClasses
()
.
Create
(
input
.
sc
)
Expect
(
err
)
.
NotTo
(
HaveOccurred
())
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment