Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
33f44a29
Unverified
Commit
33f44a29
authored
May 10, 2019
by
Kubernetes Prow Robot
Committed by
GitHub
May 10, 2019
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #77617 from cmluciano/cml/extensiontonetworking
ingress: migrate extensions.Ingress to networking.Ingress
parents
9ecc57ef
d9e4933d
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
75 additions
and
75 deletions
+75
-75
describe.go
pkg/kubectl/describe/versioned/describe.go
+6
-6
BUILD
test/e2e/framework/ingress/BUILD
+1
-1
ingress_utils.go
test/e2e/framework/ingress/ingress_utils.go
+35
-35
BUILD
test/e2e/manifest/BUILD
+2
-2
manifest.go
test/e2e/manifest/manifest.go
+5
-5
manifest_test.go
test/e2e/manifest/manifest_test.go
+2
-2
ingress.go
test/e2e/network/ingress.go
+2
-2
BUILD
test/e2e/network/scale/BUILD
+1
-1
ingress.go
test/e2e/network/scale/ingress.go
+21
-21
No files found.
pkg/kubectl/describe/versioned/describe.go
View file @
33f44a29
...
...
@@ -2291,7 +2291,7 @@ type IngressDescriber struct {
}
func
(
i
*
IngressDescriber
)
Describe
(
namespace
,
name
string
,
describerSettings
describe
.
DescriberSettings
)
(
string
,
error
)
{
c
:=
i
.
Extensions
V1beta1
()
.
Ingresses
(
namespace
)
c
:=
i
.
Networking
V1beta1
()
.
Ingresses
(
namespace
)
ing
,
err
:=
c
.
Get
(
name
,
metav1
.
GetOptions
{})
if
err
!=
nil
{
return
""
,
err
...
...
@@ -2299,7 +2299,7 @@ func (i *IngressDescriber) Describe(namespace, name string, describerSettings de
return
i
.
describeIngress
(
ing
,
describerSettings
)
}
func
(
i
*
IngressDescriber
)
describeBackend
(
ns
string
,
backend
*
extensions
v1beta1
.
IngressBackend
)
string
{
func
(
i
*
IngressDescriber
)
describeBackend
(
ns
string
,
backend
*
networking
v1beta1
.
IngressBackend
)
string
{
endpoints
,
_
:=
i
.
CoreV1
()
.
Endpoints
(
ns
)
.
Get
(
backend
.
ServiceName
,
metav1
.
GetOptions
{})
service
,
_
:=
i
.
CoreV1
()
.
Services
(
ns
)
.
Get
(
backend
.
ServiceName
,
metav1
.
GetOptions
{})
spName
:=
""
...
...
@@ -2319,7 +2319,7 @@ func (i *IngressDescriber) describeBackend(ns string, backend *extensionsv1beta1
return
formatEndpoints
(
endpoints
,
sets
.
NewString
(
spName
))
}
func
(
i
*
IngressDescriber
)
describeIngress
(
ing
*
extensions
v1beta1
.
Ingress
,
describerSettings
describe
.
DescriberSettings
)
(
string
,
error
)
{
func
(
i
*
IngressDescriber
)
describeIngress
(
ing
*
networking
v1beta1
.
Ingress
,
describerSettings
describe
.
DescriberSettings
)
(
string
,
error
)
{
return
tabbedString
(
func
(
out
io
.
Writer
)
error
{
w
:=
NewPrefixWriter
(
out
)
w
.
Write
(
LEVEL_0
,
"Name:
\t
%v
\n
"
,
ing
.
Name
)
...
...
@@ -2330,7 +2330,7 @@ func (i *IngressDescriber) describeIngress(ing *extensionsv1beta1.Ingress, descr
if
def
==
nil
{
// Ingresses that don't specify a default backend inherit the
// default backend in the kube-system namespace.
def
=
&
extensions
v1beta1
.
IngressBackend
{
def
=
&
networking
v1beta1
.
IngressBackend
{
ServiceName
:
"default-http-backend"
,
ServicePort
:
intstr
.
IntOrString
{
Type
:
intstr
.
Int
,
IntVal
:
80
},
}
...
...
@@ -2372,7 +2372,7 @@ func (i *IngressDescriber) describeIngress(ing *extensionsv1beta1.Ingress, descr
})
}
func
describeIngressTLS
(
w
PrefixWriter
,
ingTLS
[]
extensions
v1beta1
.
IngressTLS
)
{
func
describeIngressTLS
(
w
PrefixWriter
,
ingTLS
[]
networking
v1beta1
.
IngressTLS
)
{
w
.
Write
(
LEVEL_0
,
"TLS:
\n
"
)
for
_
,
t
:=
range
ingTLS
{
if
t
.
SecretName
==
""
{
...
...
@@ -4494,7 +4494,7 @@ func extractCSRStatus(csr *certificatesv1beta1.CertificateSigningRequest) (strin
}
// backendStringer behaves just like a string interface and converts the given backend to a string.
func
backendStringer
(
backend
*
extensions
v1beta1
.
IngressBackend
)
string
{
func
backendStringer
(
backend
*
networking
v1beta1
.
IngressBackend
)
string
{
if
backend
==
nil
{
return
""
}
...
...
test/e2e/framework/ingress/BUILD
View file @
33f44a29
...
...
@@ -8,7 +8,7 @@ go_library(
deps = [
"//staging/src/k8s.io/api/apps/v1:go_default_library",
"//staging/src/k8s.io/api/core/v1:go_default_library",
"//staging/src/k8s.io/api/
extensions
/v1beta1:go_default_library",
"//staging/src/k8s.io/api/
networking
/v1beta1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/labels:go_default_library",
...
...
test/e2e/framework/ingress/ingress_utils.go
View file @
33f44a29
This diff is collapsed.
Click to expand it.
test/e2e/manifest/BUILD
View file @
33f44a29
...
...
@@ -13,7 +13,7 @@ go_library(
deps = [
"//staging/src/k8s.io/api/apps/v1:go_default_library",
"//staging/src/k8s.io/api/core/v1:go_default_library",
"//staging/src/k8s.io/api/
extensions
/v1beta1:go_default_library",
"//staging/src/k8s.io/api/
networking
/v1beta1:go_default_library",
"//staging/src/k8s.io/api/rbac/v1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library",
...
...
@@ -41,5 +41,5 @@ go_test(
name = "go_default_test",
srcs = ["manifest_test.go"],
embed = [":go_default_library"],
deps = ["//staging/src/k8s.io/api/
extensions
/v1beta1:go_default_library"],
deps = ["//staging/src/k8s.io/api/
networking
/v1beta1:go_default_library"],
)
test/e2e/manifest/manifest.go
View file @
33f44a29
...
...
@@ -22,7 +22,7 @@ import (
apps
"k8s.io/api/apps/v1"
"k8s.io/api/core/v1"
extensions
"k8s.io/api/extensions
/v1beta1"
networkingv1beta1
"k8s.io/api/networking
/v1beta1"
rbac
"k8s.io/api/rbac/v1"
metav1
"k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
...
...
@@ -87,8 +87,8 @@ func SvcFromManifest(fileName string) (*v1.Service, error) {
}
// IngressFromManifest reads a .json/yaml file and returns the ingress in it.
func
IngressFromManifest
(
fileName
string
)
(
*
extensions
.
Ingress
,
error
)
{
var
ing
extensions
.
Ingress
func
IngressFromManifest
(
fileName
string
)
(
*
networkingv1beta1
.
Ingress
,
error
)
{
var
ing
networkingv1beta1
.
Ingress
data
,
err
:=
testfiles
.
Read
(
fileName
)
if
err
!=
nil
{
return
nil
,
err
...
...
@@ -106,8 +106,8 @@ func IngressFromManifest(fileName string) (*extensions.Ingress, error) {
// IngressToManifest generates a yaml file in the given path with the given ingress.
// Assumes that a directory exists at the given path.
func
IngressToManifest
(
ing
*
extensions
.
Ingress
,
path
string
)
error
{
serialized
,
err
:=
marshalToYaml
(
ing
,
extensions
.
SchemeGroupVersion
)
func
IngressToManifest
(
ing
*
networkingv1beta1
.
Ingress
,
path
string
)
error
{
serialized
,
err
:=
marshalToYaml
(
ing
,
networkingv1beta1
.
SchemeGroupVersion
)
if
err
!=
nil
{
return
fmt
.
Errorf
(
"failed to marshal ingress %v to YAML: %v"
,
ing
,
err
)
}
...
...
test/e2e/manifest/manifest_test.go
View file @
33f44a29
...
...
@@ -22,11 +22,11 @@ import (
"path/filepath"
"testing"
extensions
"k8s.io/api/extensions
/v1beta1"
networkingv1beta1
"k8s.io/api/networking
/v1beta1"
)
func
TestIngressToManifest
(
t
*
testing
.
T
)
{
ing
:=
&
extensions
.
Ingress
{}
ing
:=
&
networkingv1beta1
.
Ingress
{}
// Create a temp dir.
tmpDir
,
err
:=
ioutil
.
TempDir
(
""
,
"kubemci"
)
if
err
!=
nil
{
...
...
test/e2e/network/ingress.go
View file @
33f44a29
...
...
@@ -171,7 +171,7 @@ var _ = SIGDescribe("Loadbalancing: L7", func() {
By
(
fmt
.
Sprintf
(
"waiting for Ingress %s to get instance group annotation"
,
name
))
pollErr
:=
wait
.
Poll
(
2
*
time
.
Second
,
framework
.
LoadBalancerPollTimeout
,
func
()
(
bool
,
error
)
{
ing
,
err
:=
f
.
ClientSet
.
Extensions
V1beta1
()
.
Ingresses
(
ns
)
.
Get
(
name
,
metav1
.
GetOptions
{})
ing
,
err
:=
f
.
ClientSet
.
Networking
V1beta1
()
.
Ingresses
(
ns
)
.
Get
(
name
,
metav1
.
GetOptions
{})
framework
.
ExpectNoError
(
err
)
annotations
:=
ing
.
Annotations
if
annotations
==
nil
||
annotations
[
instanceGroupAnnotation
]
==
""
{
...
...
@@ -194,7 +194,7 @@ var _ = SIGDescribe("Loadbalancing: L7", func() {
scKey
:=
ingress
.
StatusPrefix
+
"/ssl-cert"
beKey
:=
ingress
.
StatusPrefix
+
"/backends"
wait
.
Poll
(
2
*
time
.
Second
,
time
.
Minute
,
func
()
(
bool
,
error
)
{
ing
,
err
:=
f
.
ClientSet
.
Extensions
V1beta1
()
.
Ingresses
(
ns
)
.
Get
(
name
,
metav1
.
GetOptions
{})
ing
,
err
:=
f
.
ClientSet
.
Networking
V1beta1
()
.
Ingresses
(
ns
)
.
Get
(
name
,
metav1
.
GetOptions
{})
framework
.
ExpectNoError
(
err
)
annotations
:=
ing
.
Annotations
if
annotations
!=
nil
&&
(
annotations
[
umKey
]
!=
""
||
annotations
[
fwKey
]
!=
""
||
...
...
test/e2e/network/scale/BUILD
View file @
33f44a29
...
...
@@ -8,7 +8,7 @@ go_library(
deps = [
"//staging/src/k8s.io/api/apps/v1:go_default_library",
"//staging/src/k8s.io/api/core/v1:go_default_library",
"//staging/src/k8s.io/api/
extensions
/v1beta1:go_default_library",
"//staging/src/k8s.io/api/
networking
/v1beta1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/util/intstr:go_default_library",
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
...
...
test/e2e/network/scale/ingress.go
View file @
33f44a29
...
...
@@ -24,7 +24,7 @@ import (
apps
"k8s.io/api/apps/v1"
"k8s.io/api/core/v1"
extensions
"k8s.io/api/extensions
/v1beta1"
networkingv1beta1
"k8s.io/api/networking
/v1beta1"
metav1
"k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/intstr"
clientset
"k8s.io/client-go/kubernetes"
...
...
@@ -74,7 +74,7 @@ type IngressScaleFramework struct {
ScaleTestDeploy
*
apps
.
Deployment
ScaleTestSvcs
[]
*
v1
.
Service
ScaleTestIngs
[]
*
extensions
.
Ingress
ScaleTestIngs
[]
*
networkingv1beta1
.
Ingress
// BatchCreateLatencies stores all ingress creation latencies, in different
// batches.
...
...
@@ -121,7 +121,7 @@ func (f *IngressScaleFramework) PrepareScaleTest() error {
}
f
.
ScaleTestSvcs
=
[]
*
v1
.
Service
{}
f
.
ScaleTestIngs
=
[]
*
extensions
.
Ingress
{}
f
.
ScaleTestIngs
=
[]
*
networkingv1beta1
.
Ingress
{}
return
nil
}
...
...
@@ -133,7 +133,7 @@ func (f *IngressScaleFramework) CleanupScaleTest() []error {
f
.
Logger
.
Infof
(
"Cleaning up ingresses..."
)
for
_
,
ing
:=
range
f
.
ScaleTestIngs
{
if
ing
!=
nil
{
if
err
:=
f
.
Clientset
.
Extensions
V1beta1
()
.
Ingresses
(
ing
.
Namespace
)
.
Delete
(
ing
.
Name
,
nil
);
err
!=
nil
{
if
err
:=
f
.
Clientset
.
Networking
V1beta1
()
.
Ingresses
(
ing
.
Namespace
)
.
Delete
(
ing
.
Name
,
nil
);
err
!=
nil
{
errs
=
append
(
errs
,
fmt
.
Errorf
(
"Error while deleting ingress %s/%s: %v"
,
ing
.
Namespace
,
ing
.
Name
,
err
))
}
}
...
...
@@ -190,7 +190,7 @@ func (f *IngressScaleFramework) RunScaleTest() []error {
numIngsToCreate
:=
numIngsNeeded
-
numIngsCreated
ingWg
.
Add
(
numIngsToCreate
)
svcQueue
:=
make
(
chan
*
v1
.
Service
,
numIngsToCreate
)
ingQueue
:=
make
(
chan
*
extensions
.
Ingress
,
numIngsToCreate
)
ingQueue
:=
make
(
chan
*
networkingv1beta1
.
Ingress
,
numIngsToCreate
)
errQueue
:=
make
(
chan
error
,
numIngsToCreate
)
latencyQueue
:=
make
(
chan
time
.
Duration
,
numIngsToCreate
)
start
:=
time
.
Now
()
...
...
@@ -270,14 +270,14 @@ func (f *IngressScaleFramework) RunScaleTest() []error {
f
.
StepCreateLatencies
=
append
(
f
.
StepCreateLatencies
,
elapsed
)
f
.
Logger
.
Infof
(
"Updating ingress and wait for change to take effect"
)
ingToUpdate
,
err
:=
f
.
Clientset
.
Extensions
V1beta1
()
.
Ingresses
(
f
.
Namespace
)
.
Get
(
ingCreated
.
Name
,
metav1
.
GetOptions
{})
ingToUpdate
,
err
:=
f
.
Clientset
.
Networking
V1beta1
()
.
Ingresses
(
f
.
Namespace
)
.
Get
(
ingCreated
.
Name
,
metav1
.
GetOptions
{})
if
err
!=
nil
{
errs
=
append
(
errs
,
err
)
return
}
addTestPathToIngress
(
ingToUpdate
)
start
=
time
.
Now
()
ingToUpdate
,
err
=
f
.
Clientset
.
Extensions
V1beta1
()
.
Ingresses
(
f
.
Namespace
)
.
Update
(
ingToUpdate
)
ingToUpdate
,
err
=
f
.
Clientset
.
Networking
V1beta1
()
.
Ingresses
(
f
.
Namespace
)
.
Update
(
ingToUpdate
)
if
err
!=
nil
{
errs
=
append
(
errs
,
err
)
return
...
...
@@ -357,45 +357,45 @@ func (f *IngressScaleFramework) GetFormattedLatencies() string {
return
res
}
func
addTestPathToIngress
(
ing
*
extensions
.
Ingress
)
{
func
addTestPathToIngress
(
ing
*
networkingv1beta1
.
Ingress
)
{
ing
.
Spec
.
Rules
[
0
]
.
IngressRuleValue
.
HTTP
.
Paths
=
append
(
ing
.
Spec
.
Rules
[
0
]
.
IngressRuleValue
.
HTTP
.
Paths
,
extensions
.
HTTPIngressPath
{
networkingv1beta1
.
HTTPIngressPath
{
Path
:
"/test"
,
Backend
:
ing
.
Spec
.
Rules
[
0
]
.
IngressRuleValue
.
HTTP
.
Paths
[
0
]
.
Backend
,
})
}
func
(
f
*
IngressScaleFramework
)
createScaleTestServiceIngress
(
suffix
string
,
enableTLS
bool
)
(
*
v1
.
Service
,
*
extensions
.
Ingress
,
error
)
{
func
(
f
*
IngressScaleFramework
)
createScaleTestServiceIngress
(
suffix
string
,
enableTLS
bool
)
(
*
v1
.
Service
,
*
networkingv1beta1
.
Ingress
,
error
)
{
svcCreated
,
err
:=
f
.
Clientset
.
CoreV1
()
.
Services
(
f
.
Namespace
)
.
Create
(
generateScaleTestServiceSpec
(
suffix
))
if
err
!=
nil
{
return
nil
,
nil
,
err
}
ingCreated
,
err
:=
f
.
Clientset
.
Extensions
V1beta1
()
.
Ingresses
(
f
.
Namespace
)
.
Create
(
generateScaleTestIngressSpec
(
suffix
,
enableTLS
))
ingCreated
,
err
:=
f
.
Clientset
.
Networking
V1beta1
()
.
Ingresses
(
f
.
Namespace
)
.
Create
(
generateScaleTestIngressSpec
(
suffix
,
enableTLS
))
if
err
!=
nil
{
return
nil
,
nil
,
err
}
return
svcCreated
,
ingCreated
,
nil
}
func
generateScaleTestIngressSpec
(
suffix
string
,
enableTLS
bool
)
*
extensions
.
Ingress
{
ing
:=
&
extensions
.
Ingress
{
func
generateScaleTestIngressSpec
(
suffix
string
,
enableTLS
bool
)
*
networkingv1beta1
.
Ingress
{
ing
:=
&
networkingv1beta1
.
Ingress
{
ObjectMeta
:
metav1
.
ObjectMeta
{
Name
:
fmt
.
Sprintf
(
"%s-%s"
,
scaleTestIngressNamePrefix
,
suffix
),
},
Spec
:
extensions
.
IngressSpec
{
TLS
:
[]
extensions
.
IngressTLS
{
Spec
:
networkingv1beta1
.
IngressSpec
{
TLS
:
[]
networkingv1beta1
.
IngressTLS
{
{
SecretName
:
scaleTestSecretName
},
},
Rules
:
[]
extensions
.
IngressRule
{
Rules
:
[]
networkingv1beta1
.
IngressRule
{
{
Host
:
scaleTestHostname
,
IngressRuleValue
:
extensions
.
IngressRuleValue
{
HTTP
:
&
extensions
.
HTTPIngressRuleValue
{
Paths
:
[]
extensions
.
HTTPIngressPath
{
IngressRuleValue
:
networkingv1beta1
.
IngressRuleValue
{
HTTP
:
&
networkingv1beta1
.
HTTPIngressRuleValue
{
Paths
:
[]
networkingv1beta1
.
HTTPIngressPath
{
{
Path
:
"/scale"
,
Backend
:
extensions
.
IngressBackend
{
Backend
:
networkingv1beta1
.
IngressBackend
{
ServiceName
:
fmt
.
Sprintf
(
"%s-%s"
,
scaleTestBackendName
,
suffix
),
ServicePort
:
intstr
.
IntOrString
{
Type
:
intstr
.
Int
,
...
...
@@ -411,7 +411,7 @@ func generateScaleTestIngressSpec(suffix string, enableTLS bool) *extensions.Ing
},
}
if
enableTLS
{
ing
.
Spec
.
TLS
=
[]
extensions
.
IngressTLS
{
ing
.
Spec
.
TLS
=
[]
networkingv1beta1
.
IngressTLS
{
{
SecretName
:
scaleTestSecretName
},
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment