Merge pull request #33639 from guangxuli/k8s_test_helper

Automatic merge from submit-queue if test succ remove the tmp file

Merge pull request #33639 from guangxuli/k8s_test_helper
33103e57 · Kubernetes Submit Queue · GitHub · cccd3b32 · 010bca63 · 33103e57
Commit 33103e57 authored Oct 05, 2016 by Kubernetes Submit Queue Committed by GitHub Oct 05, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

helpers_test.go pkg/kubectl/cmd/util/helpers_test.go +6 -0

No files found.
--- a/pkg/kubectl/cmd/util/helpers_test.go
+++ b/pkg/kubectl/cmd/util/helpers_test.go
@@ -20,6 +20,7 @@ import (
 	"fmt"
 	"io/ioutil"
 	"net/http"
+	"os"
 	"reflect"
 	"strings"
 	"syscall"
@@ -308,6 +309,11 @@ func TestDumpReaderToFile(t *testing.T) {
 	}
 	defer syscall.Unlink(tempFile.Name())
 	defer tempFile.Close()
+	defer func() {
+		if !t.Failed() {
+			os.Remove(tempFile.Name())
+		}
+	}()
 	err = DumpReaderToFile(strings.NewReader(testString), tempFile.Name())
 	if err != nil {
 		t.Errorf("error in DumpReaderToFile: %v", err)