Skip to content

K
k3s
Unverified Commit 32dc5047 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #58249 from ilackarms/compression-flushing

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. periodically flush ResponseWriter when using response compression This PR fixes API Compression when following logs by ensuring the compression writer periodically flushes (at the end of each write). This is a commit extracted from #51508 to allow testing of flushing while feature remains disabled / in alpha. Fixes https://github.com/kubernetes/kubernetes/issues/54205 ```release-note NONE ```
parents b6e12f1b 410b4016
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 0 deletions
staging/src/k8s.io/apiserver/pkg/server/filters/compression.go
View file @ 32dc5047
...@@ -136,6 +136,7 @@ func (c *compressionResponseWriter) Write(p []byte) (int, error) { ...@@ -136,6 +136,7 @@ func (c *compressionResponseWriter) Write(p []byte) (int, error) {
return -1, errors.New("compressing error: tried to write data using closed compressor") return -1, errors.New("compressing error: tried to write data using closed compressor")
} }
c.Header().Set(headerContentEncoding, c.encoding) c.Header().Set(headerContentEncoding, c.encoding)
defer c.compressor.Flush()
return c.compressor.Write(p) return c.compressor.Write(p)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment