Fix an unreachable kubectl explain field lookup test

In error case, the condition “gotErr != test.err && gotPath != test.expectedPath” never fulfill because in this case both gotPath and test.expectedPath always an empty string. So the err “err: `field "what?" does not exist`” doesn’t get tasted. For example, if you change the value of “err” to anything, the test still will pass. Also, since gotPath is empty string in case of err, in the output error we probably don’t want to display path.

Fix an unreachable kubectl explain field lookup test
32d8fa00 · Sahdev P. Zala · 21062657 · 32d8fa00
Commit 32d8fa00 authored Nov 07, 2017 by Sahdev P. Zala
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

field_lookup_test.go pkg/kubectl/explain/field_lookup_test.go +3 -3

No files found.
--- a/pkg/kubectl/explain/field_lookup_test.go
+++ b/pkg/kubectl/explain/field_lookup_test.go
@@ -69,9 +69,9 @@ func TestFindField(t *testing.T) {
 			gotPath = path.GetPath().String()
 		}

-		if gotErr != test.err && gotPath != test.expectedPath {
-			t.Errorf("LookupSchemaForField(schema, %v) = (%v, %v), expected (%s, %v)",
-				test.path, gotErr, gotPath, test.expectedPath, test.err)
+		if gotErr != test.err || gotPath != test.expectedPath {
+			t.Errorf("LookupSchemaForField(schema, %v) = (path: %q, err: %q), expected (path: %q, err: %q)",
+				test.path, gotPath, gotErr, test.expectedPath, test.err)
 		}
 	}
 }