Merge pull request #47515 from zhangxiaoyu-zidif/replace-scheduler-havesame

Automatic merge from submit-queue (batch tested with PRs 47043, 48448, 47515, 48446) Refactor slice intersection **What this PR does / why we need it**: In worst case, the original method is O(N^2), while current method is 3 * O(N). I think it is better. **Release note**: ```release-note NONE ```

Merge pull request #47515 from zhangxiaoyu-zidif/replace-scheduler-havesame
2f1ea7ef · Kubernetes Submit Queue · GitHub · 9a82cb20 · 22e4abaf · 2f1ea7ef
Commit 2f1ea7ef authored Jul 04, 2017 by Kubernetes Submit Queue Committed by GitHub Jul 04, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 11 additions and 5 deletions

predicates.go plugin/pkg/scheduler/algorithm/predicates/predicates.go +11 -5

No files found.
--- a/plugin/pkg/scheduler/algorithm/predicates/predicates.go
+++ b/plugin/pkg/scheduler/algorithm/predicates/predicates.go
@@ -879,11 +879,17 @@ func PodFitsHostPorts(pod *v1.Pod, meta interface{}, nodeInfo *schedulercache.No
 // search two arrays and return true if they have at least one common element; return false otherwise
 func haveSame(a1, a2 []string) bool {
-	for _, val1 := range a1 {
+	m := map[string]int{}
-		for _, val2 := range a2 {
-			if val1 == val2 {
+	for _, val := range a1 {
-				return true
+		m[val] = 1
-			}
+	}
+	for _, val := range a2 {
+		m[val] = m[val] + 1
+	}
+	for _, val := range m {
+		if val > 1 {
+			return true
 		}
 	}
 	return false