Add debugging info in pv/pvc protection e2e tests

When facing an issue which is due to lack of PV/PVC Protection finalizer on the e2e tests, the error message is just like Expected <bool>: false to be true Actually we cannot understand what happened during the tests. This adds more debugging info on the tests.

Add debugging info in pv/pvc protection e2e tests
2e6a8dee · Kenichi Omichi · 48086eb7 · 2e6a8dee · 2e6a8dee
Commit 2e6a8dee authored Oct 09, 2018 by Kenichi Omichi
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

pv_protection.go test/e2e/storage/pv_protection.go +1 -1

pvc_protection.go test/e2e/storage/pvc_protection.go +1 -1

No files found.
--- a/test/e2e/storage/pv_protection.go
+++ b/test/e2e/storage/pv_protection.go
@@ -85,7 +85,7 @@ var _ = utils.SIGDescribe("PV Protection", func() {
 		By("Checking that PV Protection finalizer is set")
 		pv, err = client.CoreV1().PersistentVolumes().Get(pv.Name, metav1.GetOptions{})
 		Expect(err).NotTo(HaveOccurred(), "While getting PV status")
-		Expect(slice.ContainsString(pv.ObjectMeta.Finalizers, volumeutil.PVProtectionFinalizer, nil)).To(BeTrue())
+		Expect(slice.ContainsString(pv.ObjectMeta.Finalizers, volumeutil.PVProtectionFinalizer, nil)).To(BeTrue(), "PV Protection finalizer(%v) is not set in %v", volumeutil.PVProtectionFinalizer, pv.ObjectMeta.Finalizers)
 	})

 	AfterEach(func() {

--- a/test/e2e/storage/pvc_protection.go
+++ b/test/e2e/storage/pvc_protection.go
@@ -63,7 +63,7 @@ var _ = utils.SIGDescribe("PVC Protection", func() {
 		By("Checking that PVC Protection finalizer is set")
 		pvc, err = client.CoreV1().PersistentVolumeClaims(pvc.Namespace).Get(pvc.Name, metav1.GetOptions{})
 		Expect(err).NotTo(HaveOccurred(), "While getting PVC status")
-		Expect(slice.ContainsString(pvc.ObjectMeta.Finalizers, volumeutil.PVCProtectionFinalizer, nil)).To(BeTrue())
+		Expect(slice.ContainsString(pvc.ObjectMeta.Finalizers, volumeutil.PVCProtectionFinalizer, nil)).To(BeTrue(), "PVC Protection finalizer(%v) is not set in %v", volumeutil.PVCProtectionFinalizer, pvc.ObjectMeta.Finalizers)
 	})

 	AfterEach(func() {