Skip to content

K
k3s
Commit 2d12c9ff authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #35138 from MrHohn/kubedns-comment

Automatic merge from submit-queue Add comment for why EndpointsStore doesn't have DeleteFunc I was confused about why EndpointsStore does not need to have the DeleteFunc. I think it would be helpful to have a comment here. @bprashanth @bowei
parents 5863a3a3 40b1a075
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 0 deletions
pkg/dns/dns.go
View file @ 2d12c9ff
...@@ -225,6 +225,8 @@ func (kd *KubeDNS) setEndpointsStore() { ...@@ -225,6 +225,8 @@ func (kd *KubeDNS) setEndpointsStore() {
// TODO: Avoid unwanted updates. // TODO: Avoid unwanted updates.
kd.handleEndpointAdd(newObj) kd.handleEndpointAdd(newObj)
}, },
// No DeleteFunc for EndpointsStore because endpoint object will be deleted
// when corresponding service is deleted.
}, },
) )
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment