Commit 2ae4ab4b authored by Xing Zhou's avatar Xing Zhou

Added validation for API server's 'apiserver-count' flag.

--apiserver-count should be a positive number, otherwise will cause errors when reconciling endpoints in MasterCountEndpointsReconciler.
parent 7e1cacaa
......@@ -116,7 +116,7 @@ func (s *ServerRunOptions) AddFlags(fs *pflag.FlagSet) {
"Currently only applies to long-running requests.")
fs.IntVar(&s.MasterCount, "apiserver-count", s.MasterCount,
"The number of apiservers running in the cluster.")
"The number of apiservers running in the cluster, must be a positive number.")
// See #14282 for details on how to test/try this option out.
// TODO: remove this comment once this option is tested in CI.
......
......@@ -63,5 +63,8 @@ func (options *ServerRunOptions) Validate() []error {
if errs := options.InsecureServing.Validate("insecure-port"); len(errs) > 0 {
errors = append(errors, errs...)
}
if options.MasterCount <= 0 {
errors = append(errors, fmt.Errorf("--apiserver-count should be a positive number, but value '%d' provided", options.MasterCount))
}
return errors
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment