Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
2ab36816
Commit
2ab36816
authored
May 23, 2019
by
Zihong Zheng
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix-up and add unit test for Load Balancer finalizer
parent
aa3f81d6
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
51 additions
and
1 deletion
+51
-1
service_controller_test.go
pkg/controller/service/service_controller_test.go
+0
-0
helper_test.go
.../src/k8s.io/cloud-provider/service/helpers/helper_test.go
+51
-1
No files found.
pkg/controller/service/service_controller_test.go
View file @
2ab36816
This diff is collapsed.
Click to expand it.
staging/src/k8s.io/cloud-provider/service/helpers/helper_test.go
View file @
2ab36816
...
...
@@ -20,7 +20,8 @@ import (
"strings"
"testing"
"k8s.io/api/core/v1"
v1
"k8s.io/api/core/v1"
metav1
"k8s.io/apimachinery/pkg/apis/meta/v1"
utilnet
"k8s.io/utils/net"
)
...
...
@@ -219,3 +220,52 @@ func TestNeedsHealthCheck(t *testing.T) {
},
})
}
func
TestHasLBFinalizer
(
t
*
testing
.
T
)
{
testCases
:=
[]
struct
{
desc
string
svc
*
v1
.
Service
hasFinalizer
bool
}{
{
desc
:
"service without finalizer"
,
svc
:
&
v1
.
Service
{},
hasFinalizer
:
false
,
},
{
desc
:
"service with unrelated finalizer"
,
svc
:
&
v1
.
Service
{
ObjectMeta
:
metav1
.
ObjectMeta
{
Finalizers
:
[]
string
{
"unrelated"
},
},
},
hasFinalizer
:
false
,
},
{
desc
:
"service with one finalizer"
,
svc
:
&
v1
.
Service
{
ObjectMeta
:
metav1
.
ObjectMeta
{
Finalizers
:
[]
string
{
LoadBalancerCleanupFinalizer
},
},
},
hasFinalizer
:
true
,
},
{
desc
:
"service with multiple finalizers"
,
svc
:
&
v1
.
Service
{
ObjectMeta
:
metav1
.
ObjectMeta
{
Finalizers
:
[]
string
{
LoadBalancerCleanupFinalizer
,
"unrelated"
},
},
},
hasFinalizer
:
true
,
},
}
for
_
,
tc
:=
range
testCases
{
t
.
Run
(
tc
.
desc
,
func
(
t
*
testing
.
T
)
{
if
hasFinalizer
:=
HasLBFinalizer
(
tc
.
svc
);
hasFinalizer
!=
tc
.
hasFinalizer
{
t
.
Errorf
(
"HasLBFinalizer() = %t, want %t"
,
hasFinalizer
,
tc
.
hasFinalizer
)
}
})
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment