Commit 2a3ffe40 authored by Tomás Senart's avatar Tomás Senart

kubelet: Use assert.EqualValues instead of assert.Equal

The last update to github.com/stretchr/testify makes `assert.Equal` consider the type of its arguments. This commit makes this test pass again by only testing for value equality using `assert.EqualValues`.
parent 5d51891d
...@@ -216,7 +216,7 @@ func TestFreeSpaceImagesInUseContainersAreIgnored(t *testing.T) { ...@@ -216,7 +216,7 @@ func TestFreeSpaceImagesInUseContainersAreIgnored(t *testing.T) {
spaceFreed, err := manager.freeSpace(2048) spaceFreed, err := manager.freeSpace(2048)
assert := assert.New(t) assert := assert.New(t)
require.NoError(t, err) require.NoError(t, err)
assert.Equal(1024, spaceFreed) assert.EqualValues(1024, spaceFreed)
assert.Len(fakeDocker.RemovedImages, 1) assert.Len(fakeDocker.RemovedImages, 1)
assert.True(fakeDocker.RemovedImages.Has(imageName(0))) assert.True(fakeDocker.RemovedImages.Has(imageName(0)))
} }
...@@ -245,7 +245,7 @@ func TestFreeSpaceRemoveByLeastRecentlyUsed(t *testing.T) { ...@@ -245,7 +245,7 @@ func TestFreeSpaceRemoveByLeastRecentlyUsed(t *testing.T) {
spaceFreed, err := manager.freeSpace(1024) spaceFreed, err := manager.freeSpace(1024)
assert := assert.New(t) assert := assert.New(t)
require.NoError(t, err) require.NoError(t, err)
assert.Equal(1024, spaceFreed) assert.EqualValues(1024, spaceFreed)
assert.Len(fakeDocker.RemovedImages, 1) assert.Len(fakeDocker.RemovedImages, 1)
assert.True(fakeDocker.RemovedImages.Has(imageName(0))) assert.True(fakeDocker.RemovedImages.Has(imageName(0)))
} }
...@@ -277,7 +277,7 @@ func TestFreeSpaceTiesBrokenByDetectedTime(t *testing.T) { ...@@ -277,7 +277,7 @@ func TestFreeSpaceTiesBrokenByDetectedTime(t *testing.T) {
spaceFreed, err := manager.freeSpace(1024) spaceFreed, err := manager.freeSpace(1024)
assert := assert.New(t) assert := assert.New(t)
require.NoError(t, err) require.NoError(t, err)
assert.Equal(1024, spaceFreed) assert.EqualValues(1024, spaceFreed)
assert.Len(fakeDocker.RemovedImages, 1) assert.Len(fakeDocker.RemovedImages, 1)
assert.True(fakeDocker.RemovedImages.Has(imageName(0))) assert.True(fakeDocker.RemovedImages.Has(imageName(0)))
} }
...@@ -302,7 +302,7 @@ func TestFreeSpaceImagesAlsoDoesLookupByRepoTags(t *testing.T) { ...@@ -302,7 +302,7 @@ func TestFreeSpaceImagesAlsoDoesLookupByRepoTags(t *testing.T) {
spaceFreed, err := manager.freeSpace(1024) spaceFreed, err := manager.freeSpace(1024)
assert := assert.New(t) assert := assert.New(t)
require.NoError(t, err) require.NoError(t, err)
assert.Equal(1024, spaceFreed) assert.EqualValues(1024, spaceFreed)
assert.Len(fakeDocker.RemovedImages, 1) assert.Len(fakeDocker.RemovedImages, 1)
assert.True(fakeDocker.RemovedImages.Has(imageName(0))) assert.True(fakeDocker.RemovedImages.Has(imageName(0)))
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment