Commit 28a6a446 authored by Jonathan Basseri's avatar Jonathan Basseri

Allow FeatureGate values to be overridden in benchmarks.

This updates `SetFeatureGateDuringTest` to use the `testing.TB` interface, which matches *testing.T and *testing.B.
parent 94806e6a
......@@ -29,16 +29,16 @@ import (
// Example use:
//
// defer utilfeaturetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.<FeatureName>, true)()
func SetFeatureGateDuringTest(t *testing.T, gate feature.FeatureGate, f feature.Feature, value bool) func() {
func SetFeatureGateDuringTest(tb testing.TB, gate feature.FeatureGate, f feature.Feature, value bool) func() {
originalValue := gate.Enabled(f)
if err := gate.(feature.MutableFeatureGate).Set(fmt.Sprintf("%s=%v", f, value)); err != nil {
t.Errorf("error setting %s=%v: %v", f, value, err)
tb.Errorf("error setting %s=%v: %v", f, value, err)
}
return func() {
if err := gate.(feature.MutableFeatureGate).Set(fmt.Sprintf("%s=%v", f, originalValue)); err != nil {
t.Errorf("error restoring %s=%v: %v", f, originalValue, err)
tb.Errorf("error restoring %s=%v: %v", f, originalValue, err)
}
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment