should check return err

26626529 · stewart-yu · 0a3cf593 · 26626529
Commit 26626529 authored Nov 26, 2017 by stewart-yu
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

controllermanager.go cmd/cloud-controller-manager/app/controllermanager.go +3 -3

No files found.
--- a/cmd/cloud-controller-manager/app/controllermanager.go
+++ b/cmd/cloud-controller-manager/app/controllermanager.go
@@ -143,9 +143,9 @@ func Run(s *options.CloudControllerManagerServer) error {
 			clientBuilder = rootClientBuilder
 		}

-		err := StartControllers(s, kubeconfig, clientBuilder, stop, recorder, cloud)
-		glog.Fatalf("error running controllers: %v", err)
-		panic("unreachable")
+		if err := StartControllers(s, kubeconfig, clientBuilder, stop, recorder, cloud); err != nil {
+			glog.Fatalf("error running controllers: %v", err)
+		}
 	}

 	if !s.LeaderElection.LeaderElect {