Merge pull request #60103 from mikedanese/fix-test

Automatic merge from submit-queue (batch tested with PRs 59934, 60098, 60103, 60104, 60109). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cloud: don't require application default credentials to run unit tests Introduced in https://github.com/kubernetes/kubernetes/pull/59490 ```release-note NONE ```

Merge pull request #60103 from mikedanese/fix-test
202ef1e6 · Kubernetes Submit Queue · GitHub · 36f824b6 · a9e0a2b0 · 202ef1e6
Unverified Commit 202ef1e6 authored Feb 20, 2018 by Kubernetes Submit Queue Committed by GitHub Feb 20, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 5 deletions

gce_loadbalancer_external_test.go ...dprovider/providers/gce/gce_loadbalancer_external_test.go +9 -5

No files found.
--- a/pkg/cloudprovider/providers/gce/gce_loadbalancer_external_test.go
+++ b/pkg/cloudprovider/providers/gce/gce_loadbalancer_external_test.go
@@ -18,6 +18,7 @@ package gce
 import (
 	"fmt"
+	"net/http"
 	"testing"
 	"github.com/stretchr/testify/assert"
@@ -261,13 +262,16 @@ var apiService = &v1.Service{
 	},
 }
+type fakeRoundTripper struct{}
+func (*fakeRoundTripper) RoundTrip(*http.Request) (*http.Response, error) {
+	return nil, fmt.Errorf("err: test used fake http client")
+}
 func fakeGCECloud() (*GCECloud, error) {
-	client, err := newOauthClient(nil)
+	c := &http.Client{Transport: &fakeRoundTripper{}}
-	if err != nil {
-		return nil, err
-	}
-	service, err := compute.New(client)
+	service, err := compute.New(c)
 	if err != nil {
 		return nil, err
 	}