Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
1bb48098
Commit
1bb48098
authored
Oct 07, 2015
by
saadali
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prevent GCE PD attach code from succeding if disk failed to attach.
parent
3902f765
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
2 deletions
+6
-2
gce_util.go
pkg/volume/gce_pd/gce_util.go
+6
-2
No files found.
pkg/volume/gce_pd/gce_util.go
View file @
1bb48098
...
@@ -125,6 +125,9 @@ func attachDiskAndVerify(b *gcePersistentDiskBuilder, sdBeforeSet sets.String) (
...
@@ -125,6 +125,9 @@ func attachDiskAndVerify(b *gcePersistentDiskBuilder, sdBeforeSet sets.String) (
devicePaths
:=
getDiskByIdPaths
(
b
.
gcePersistentDisk
)
devicePaths
:=
getDiskByIdPaths
(
b
.
gcePersistentDisk
)
var
gceCloud
*
gce_cloud
.
GCECloud
var
gceCloud
*
gce_cloud
.
GCECloud
for
numRetries
:=
0
;
numRetries
<
maxRetries
;
numRetries
++
{
for
numRetries
:=
0
;
numRetries
<
maxRetries
;
numRetries
++
{
// Block execution until any pending detach goroutines for this pd have completed
detachCleanupManager
.
Send
(
b
.
pdName
,
true
)
var
err
error
var
err
error
if
gceCloud
==
nil
{
if
gceCloud
==
nil
{
gceCloud
,
err
=
getCloudProvider
()
gceCloud
,
err
=
getCloudProvider
()
...
@@ -141,9 +144,10 @@ func attachDiskAndVerify(b *gcePersistentDiskBuilder, sdBeforeSet sets.String) (
...
@@ -141,9 +144,10 @@ func attachDiskAndVerify(b *gcePersistentDiskBuilder, sdBeforeSet sets.String) (
}
}
if
err
:=
gceCloud
.
AttachDisk
(
b
.
pdName
,
b
.
readOnly
);
err
!=
nil
{
if
err
:=
gceCloud
.
AttachDisk
(
b
.
pdName
,
b
.
readOnly
);
err
!=
nil
{
// Retry on error. See issue #11321. Continue and verify if disk is attached, because a
// Retry on error. See issue #11321.
// previous attach operation may still succeed.
glog
.
Errorf
(
"Error attaching PD %q: %v"
,
b
.
pdName
,
err
)
glog
.
Errorf
(
"Error attaching PD %q: %v"
,
b
.
pdName
,
err
)
time
.
Sleep
(
errorSleepDuration
)
continue
}
}
for
numChecks
:=
0
;
numChecks
<
maxChecks
;
numChecks
++
{
for
numChecks
:=
0
;
numChecks
<
maxChecks
;
numChecks
++
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment