Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
1af76aee
Unverified
Commit
1af76aee
authored
Nov 08, 2018
by
k8s-ci-robot
Committed by
GitHub
Nov 08, 2018
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #69863 from stewart-yu/stewart-cloud-controller-manager-clean
fix register wrong configz for *-controller-manager
parents
c5b453b7
a2942e5f
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
2 deletions
+6
-2
controllermanager.go
cmd/cloud-controller-manager/app/controllermanager.go
+3
-1
controllermanager.go
cmd/kube-controller-manager/app/controllermanager.go
+3
-1
No files found.
cmd/cloud-controller-manager/app/controllermanager.go
View file @
1af76aee
...
@@ -50,6 +50,8 @@ import (
...
@@ -50,6 +50,8 @@ import (
const
(
const
(
// ControllerStartJitter is the jitter value used when starting controller managers.
// ControllerStartJitter is the jitter value used when starting controller managers.
ControllerStartJitter
=
1.0
ControllerStartJitter
=
1.0
// ConfigzName is the name used for register cloud-controller manager /configz, same with GroupName.
ConfigzName
=
"cloudcontrollermanager.config.k8s.io"
)
)
// NewCloudControllerManagerCommand creates a *cobra.Command object with default parameters
// NewCloudControllerManagerCommand creates a *cobra.Command object with default parameters
...
@@ -123,7 +125,7 @@ func Run(c *cloudcontrollerconfig.CompletedConfig, stopCh <-chan struct{}) error
...
@@ -123,7 +125,7 @@ func Run(c *cloudcontrollerconfig.CompletedConfig, stopCh <-chan struct{}) error
}
}
// setup /configz endpoint
// setup /configz endpoint
if
cz
,
err
:=
configz
.
New
(
"componentconfig"
);
err
==
nil
{
if
cz
,
err
:=
configz
.
New
(
ConfigzName
);
err
==
nil
{
cz
.
Set
(
c
.
ComponentConfig
)
cz
.
Set
(
c
.
ComponentConfig
)
}
else
{
}
else
{
glog
.
Errorf
(
"unable to register configz: %c"
,
err
)
glog
.
Errorf
(
"unable to register configz: %c"
,
err
)
...
...
cmd/kube-controller-manager/app/controllermanager.go
View file @
1af76aee
...
@@ -64,6 +64,8 @@ import (
...
@@ -64,6 +64,8 @@ import (
const
(
const
(
// Jitter used when starting controller managers
// Jitter used when starting controller managers
ControllerStartJitter
=
1.0
ControllerStartJitter
=
1.0
// ConfigzName is the name used for register kube-controller manager /configz, same with GroupName.
ConfigzName
=
"kubecontrollermanager.config.k8s.io"
)
)
type
ControllerLoopMode
int
type
ControllerLoopMode
int
...
@@ -142,7 +144,7 @@ func Run(c *config.CompletedConfig, stopCh <-chan struct{}) error {
...
@@ -142,7 +144,7 @@ func Run(c *config.CompletedConfig, stopCh <-chan struct{}) error {
// To help debugging, immediately log version
// To help debugging, immediately log version
glog
.
Infof
(
"Version: %+v"
,
version
.
Get
())
glog
.
Infof
(
"Version: %+v"
,
version
.
Get
())
if
cfgz
,
err
:=
configz
.
New
(
"componentconfig"
);
err
==
nil
{
if
cfgz
,
err
:=
configz
.
New
(
ConfigzName
);
err
==
nil
{
cfgz
.
Set
(
c
.
ComponentConfig
)
cfgz
.
Set
(
c
.
ComponentConfig
)
}
else
{
}
else
{
glog
.
Errorf
(
"unable to register configz: %c"
,
err
)
glog
.
Errorf
(
"unable to register configz: %c"
,
err
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment