Skip to content

K
k3s
Commit 19650207 authored by k8s-merge-robot's avatar k8s-merge-robot Committed by GitHub
Browse files
Options

Merge pull request #24678 from ericchiang/log_webhook_error

Automatic merge from submit-queue plugin/pkg/auth/authorizer/webhook: log request errors Currently the API server only checks the errors returned by an authorizer plugin, it doesn't return or log them[0]. This makes incorrectly configuring the wehbook authorizer plugin extremely difficult to debug. Add a logging statement if the request to the remove service fails as this indicates misconfiguration. [0] https://goo.gl/9zZFv4 <!-- Reviewable:start --> --- This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/24678) <!-- Reviewable:end -->
parents 2d358715 c8ca49ec
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
plugin/pkg/auth/authorizer/webhook/webhook.go
View file @ 19650207
...@@ -23,6 +23,8 @@ import ( ...@@ -23,6 +23,8 @@ import (
"fmt" "fmt"
"time" "time"
"github.com/golang/glog"
"k8s.io/kubernetes/pkg/api/unversioned" "k8s.io/kubernetes/pkg/api/unversioned"
"k8s.io/kubernetes/pkg/apis/authorization/v1beta1" "k8s.io/kubernetes/pkg/apis/authorization/v1beta1"
"k8s.io/kubernetes/pkg/auth/authorizer" "k8s.io/kubernetes/pkg/auth/authorizer"
...@@ -160,6 +162,8 @@ func (w *WebhookAuthorizer) Authorize(attr authorizer.Attributes) (err error) { ...@@ -160,6 +162,8 @@ func (w *WebhookAuthorizer) Authorize(attr authorizer.Attributes) (err error) {
return w.RestClient.Post().Body(r).Do() return w.RestClient.Post().Body(r).Do()
}) })
if err := result.Error(); err != nil { if err := result.Error(); err != nil {
// An error here indicates bad configuration or an outage. Log for debugging.
glog.Errorf("Failed to make webhook authorizer request: %v", err)
return err return err
} }
var statusCode int var statusCode int
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment