Commit 15946ddd authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub

Merge pull request #29611 from ping035627/ping035627-patch-0726

Automatic merge from submit-queue add DefaultServiceNodePortRange const The PR add DefaultServiceNodePortRange const in server_run_options.go, and use it in genericapiserver.go and server_run_options.go.
parents 2301ab7e eba0d125
...@@ -285,8 +285,7 @@ func setDefaults(c *Config) { ...@@ -285,8 +285,7 @@ func setDefaults(c *Config) {
// We should probably allow this for clouds that don't require NodePort to do load-balancing (GCE) // We should probably allow this for clouds that don't require NodePort to do load-balancing (GCE)
// but then that breaks the strict nestedness of ServiceType. // but then that breaks the strict nestedness of ServiceType.
// Review post-v1 // Review post-v1
defaultServiceNodePortRange := utilnet.PortRange{Base: 30000, Size: 2768} c.ServiceNodePortRange = options.DefaultServiceNodePortRange
c.ServiceNodePortRange = defaultServiceNodePortRange
glog.Infof("Node port range unspecified. Defaulting to %v.", c.ServiceNodePortRange) glog.Infof("Node port range unspecified. Defaulting to %v.", c.ServiceNodePortRange)
} }
if c.MasterCount == 0 { if c.MasterCount == 0 {
......
...@@ -46,6 +46,8 @@ const ( ...@@ -46,6 +46,8 @@ const (
defaultLongRunningRequestRE = "(/|^)((watch|proxy)(/|$)|(logs?|portforward|exec|attach)/?$)" defaultLongRunningRequestRE = "(/|^)((watch|proxy)(/|$)|(logs?|portforward|exec|attach)/?$)"
) )
var DefaultServiceNodePortRange = utilnet.PortRange{Base: 30000, Size: 2768}
// ServerRunOptions contains the options while running a generic api server. // ServerRunOptions contains the options while running a generic api server.
type ServerRunOptions struct { type ServerRunOptions struct {
APIGroupPrefix string APIGroupPrefix string
...@@ -133,7 +135,7 @@ func NewServerRunOptions() *ServerRunOptions { ...@@ -133,7 +135,7 @@ func NewServerRunOptions() *ServerRunOptions {
MinRequestTimeout: 1800, MinRequestTimeout: 1800,
RuntimeConfig: make(config.ConfigurationMap), RuntimeConfig: make(config.ConfigurationMap),
SecurePort: 6443, SecurePort: 6443,
ServiceNodePortRange: utilnet.PortRange{Base: 30000, Size: 2768}, ServiceNodePortRange: DefaultServiceNodePortRange,
StorageVersions: registered.AllPreferredGroupVersions(), StorageVersions: registered.AllPreferredGroupVersions(),
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment