Merge pull request #66014 from yue9944882/cleanup-podpreset-unused-methods

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Clean up podpreset admission controller unused methods **What this PR does / why we need it**: As the title. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```

Merge pull request #66014 from yue9944882/cleanup-podpreset-unused-methods
14ee31b7 · Kubernetes Submit Queue · GitHub · 259e0743 · 12671628 · 14ee31b7
Unverified Commit 14ee31b7 authored Jul 31, 2018 by Kubernetes Submit Queue Committed by GitHub Jul 31, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 26 deletions

BUILD plugin/pkg/admission/podpreset/BUILD +0 -2

admission.go plugin/pkg/admission/podpreset/admission.go +0 -24

No files found.
--- a/plugin/pkg/admission/podpreset/BUILD
+++ b/plugin/pkg/admission/podpreset/BUILD
@@ -29,8 +29,6 @@ go_library(
    srcs = ["admission.go"],
    importpath = "k8s.io/kubernetes/plugin/pkg/admission/podpreset",
    deps = [
-        "//pkg/api/legacyscheme:go_default_library",
-        "//pkg/api/ref:go_default_library",
        "//pkg/apis/core:go_default_library",
        "//pkg/apis/settings:go_default_library",
        "//pkg/client/clientset_generated/internalclientset:go_default_library",

--- a/plugin/pkg/admission/podpreset/admission.go
+++ b/plugin/pkg/admission/podpreset/admission.go
@@ -29,8 +29,6 @@ import (
 	"k8s.io/apimachinery/pkg/labels"
 	utilerrors "k8s.io/apimachinery/pkg/util/errors"
 	"k8s.io/apiserver/pkg/admission"
-	"k8s.io/kubernetes/pkg/api/legacyscheme"
-	"k8s.io/kubernetes/pkg/api/ref"
 	api "k8s.io/kubernetes/pkg/apis/core"
 	"k8s.io/kubernetes/pkg/apis/settings"
 	"k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset"
@@ -347,28 +345,6 @@ func mergeVolumes(volumes []api.Volume, podPresets []*settings.PodPreset) ([]api
 	return mergedVolumes, err
 }

-func (c *podPresetPlugin) addEvent(pod *api.Pod, pip *settings.PodPreset, message string) {
-	ref, err := ref.GetReference(legacyscheme.Scheme, pod)
-	if err != nil {
-		glog.Errorf("pip %s: get reference for pod %s failed: %v", pip.GetName(), pod.GetName(), err)
-		return
-	}
-
-	e := &api.Event{
-		InvolvedObject: *ref,
-		Message:        message,
-		Source: api.EventSource{
-			Component: fmt.Sprintf("pip %s", pip.GetName()),
-		},
-		Type: "Warning",
-	}
-
-	if _, err := c.client.Core().Events(pod.GetNamespace()).Create(e); err != nil {
-		glog.Errorf("pip %s: creating pod event failed: %v", pip.GetName(), err)
-		return
-	}
-}
-
 // applyPodPresetsOnPod updates the PodSpec with merged information from all the
 // applicable PodPresets. It ignores the errors of merge functions because merge
 // errors have already been checked in safeToApplyPodPresetsOnPod function.