Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
11fabf11
Commit
11fabf11
authored
Jan 14, 2019
by
David Zhu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove client impersonantion from ClusterRole creation
parent
6b8c2e07
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
23 deletions
+3
-23
create.go
test/e2e/framework/create.go
+3
-23
No files found.
test/e2e/framework/create.go
View file @
11fabf11
...
...
@@ -31,8 +31,6 @@ import (
metav1
"k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/schema"
clientset
"k8s.io/client-go/kubernetes"
restclient
"k8s.io/client-go/rest"
"k8s.io/client-go/tools/cache"
"k8s.io/kubernetes/pkg/api/legacyscheme"
"k8s.io/kubernetes/test/e2e/framework/testfiles"
...
...
@@ -397,27 +395,9 @@ func (*clusterRoleFactory) Create(f *Framework, i interface{}) (func() error, er
return
nil
,
ItemNotSupported
}
// Impersonation is required for Kubernetes < 1.12, see
// https://github.com/kubernetes/kubernetes/issues/62237#issuecomment-429315111
//
// This code is kept even for more recent Kubernetes, because users of
// the framework outside of Kubernetes might run against an older version
// of Kubernetes. It will be deprecated eventually.
//
// TODO: is this only needed for a ClusterRole or also for other non-namespaced
// items?
Logf
(
"Creating an impersonating superuser kubernetes clientset to define cluster role"
)
rc
,
err
:=
LoadConfig
()
ExpectNoError
(
err
)
rc
.
Impersonate
=
restclient
.
ImpersonationConfig
{
UserName
:
"superuser"
,
Groups
:
[]
string
{
"system:masters"
},
}
superuserClientset
,
err
:=
clientset
.
NewForConfig
(
rc
)
ExpectNoError
(
err
,
"create superuser clientset"
)
client
:=
superuserClientset
.
RbacV1
()
.
ClusterRoles
()
if
_
,
err
=
client
.
Create
(
item
);
err
!=
nil
{
Logf
(
"Define cluster role %v"
,
item
.
GetName
())
client
:=
f
.
ClientSet
.
RbacV1
()
.
ClusterRoles
()
if
_
,
err
:=
client
.
Create
(
item
);
err
!=
nil
{
return
nil
,
errors
.
Wrap
(
err
,
"create ClusterRole"
)
}
return
func
()
error
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment