Skip to content

K
k3s
Commit 1199d422 authored by Kubernetes Submit Queue's avatar Kubernetes Submit Queue Committed by GitHub
Browse files
Options

Merge pull request #36702 from fabxc/client-metrics

Automatic merge from submit-queue (batch tested with PRs 37701, 36702, 37145, 37424, 38261) Limit unbound label cardinality on request errors This converts all request errors to the string `<error>` instead of passing the full error string. Error strings can have arbitrary values and thus have a cardinality that is not suitable for a metric use case. Inspecting individual errors is a logging use case which can be handled separately by registering a client error handler. @kubernetes/sig-instrumentation
parents b121411f a247736f
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 2 deletions
pkg/client/restclient/request.go
View file @ 1199d422
......@@ -694,9 +694,10 @@ func updateURLMetrics(req *Request, resp *http.Response, err error) {
url = req.baseURL.Host
}
// If we have an error (i.e. apiserver down) we report that as a metric label.
// Errors can be arbitrary strings. Unbound label cardinality is not suitable for a metric
// system so we just report them as `<error>`.
if err != nil {
metrics.RequestResult.Increment(err.Error(), req.verb, url)
metrics.RequestResult.Increment("<error>", req.verb, url)
} else {
//Metrics for failure codes
metrics.RequestResult.Increment(strconv.Itoa(resp.StatusCode), req.verb, url)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment