Commit 10969e1b authored by Dr. Stefan Schimanski's avatar Dr. Stefan Schimanski

admission/webhook: fix panic from empty response in mutating webhooks

parent 72f8a369
...@@ -20,6 +20,7 @@ package mutating ...@@ -20,6 +20,7 @@ package mutating
import ( import (
"context" "context"
"fmt"
"time" "time"
jsonpatch "github.com/evanphx/json-patch" jsonpatch "github.com/evanphx/json-patch"
...@@ -88,6 +89,10 @@ func (a *mutatingDispatcher) callAttrMutatingHook(ctx context.Context, h *v1beta ...@@ -88,6 +89,10 @@ func (a *mutatingDispatcher) callAttrMutatingHook(ctx context.Context, h *v1beta
return &webhookerrors.ErrCallingWebhook{WebhookName: h.Name, Reason: err} return &webhookerrors.ErrCallingWebhook{WebhookName: h.Name, Reason: err}
} }
if response.Response == nil {
return &webhookerrors.ErrCallingWebhook{WebhookName: h.Name, Reason: fmt.Errorf("Webhook response was absent")}
}
if !response.Response.Allowed { if !response.Response.Allowed {
return webhookerrors.ToStatusErr(h.Name, response.Response.Result) return webhookerrors.ToStatusErr(h.Name, response.Response.Result)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment