Skip to content

K
k3s
Commit 10141ebc authored by k8s-merge-robot's avatar k8s-merge-robot Committed by GitHub
Browse files
Options

Merge pull request #28757 from resouer/nit-fix

Automatic merge from submit-queue Remove no needed todo ref #19645 #13418 Remove comment about refactoring pod cleanup since we have agree to keep it. cc @yujuhong
parents 9b74e24f 1ad92359
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 3 deletions
pkg/kubelet/kubelet.go
View file @ 10141ebc
...@@ -2018,9 +2018,8 @@ type empty struct{} ...@@ -2018,9 +2018,8 @@ type empty struct{}
// HandlePodCleanups performs a series of cleanup work, including terminating // HandlePodCleanups performs a series of cleanup work, including terminating
// pod workers, killing unwanted pods, and removing orphaned volumes/pod // pod workers, killing unwanted pods, and removing orphaned volumes/pod
// directories. // directories.
// TODO(yujuhong): This function is executed by the main sync loop, so it // NOTE: This function is executed by the main sync loop, so it
// should not contain any blocking calls. Re-examine the function and decide // should not contain any blocking calls.
// whether or not we should move it into a separte goroutine.
func (kl *Kubelet) HandlePodCleanups() error { func (kl *Kubelet) HandlePodCleanups() error {
allPods, mirrorPods := kl.podManager.GetPodsAndMirrorPods() allPods, mirrorPods := kl.podManager.GetPodsAndMirrorPods()
// Pod phase progresses monotonically. Once a pod has reached a final state, // Pod phase progresses monotonically. Once a pod has reached a final state,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment