Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
K
k3s
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Jacklull
k3s
Commits
0a5f0127
Unverified
Commit
0a5f0127
authored
Aug 22, 2018
by
Jordan Liggitt
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make aws cloud provider report a node hostname address
parent
0e31372b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
2 deletions
+5
-2
aws.go
pkg/cloudprovider/providers/aws/aws.go
+2
-0
aws_test.go
pkg/cloudprovider/providers/aws/aws_test.go
+3
-2
No files found.
pkg/cloudprovider/providers/aws/aws.go
View file @
0a5f0127
...
@@ -1245,6 +1245,7 @@ func (c *Cloud) NodeAddresses(ctx context.Context, name types.NodeName) ([]v1.No
...
@@ -1245,6 +1245,7 @@ func (c *Cloud) NodeAddresses(ctx context.Context, name types.NodeName) ([]v1.No
glog
.
V
(
4
)
.
Info
(
"Could not determine private DNS from AWS metadata."
)
glog
.
V
(
4
)
.
Info
(
"Could not determine private DNS from AWS metadata."
)
}
else
{
}
else
{
addresses
=
append
(
addresses
,
v1
.
NodeAddress
{
Type
:
v1
.
NodeInternalDNS
,
Address
:
internalDNS
})
addresses
=
append
(
addresses
,
v1
.
NodeAddress
{
Type
:
v1
.
NodeInternalDNS
,
Address
:
internalDNS
})
addresses
=
append
(
addresses
,
v1
.
NodeAddress
{
Type
:
v1
.
NodeHostName
,
Address
:
internalDNS
})
}
}
externalDNS
,
err
:=
c
.
metadata
.
GetMetadata
(
"public-hostname"
)
externalDNS
,
err
:=
c
.
metadata
.
GetMetadata
(
"public-hostname"
)
...
@@ -1307,6 +1308,7 @@ func extractNodeAddresses(instance *ec2.Instance) ([]v1.NodeAddress, error) {
...
@@ -1307,6 +1308,7 @@ func extractNodeAddresses(instance *ec2.Instance) ([]v1.NodeAddress, error) {
privateDNSName
:=
aws
.
StringValue
(
instance
.
PrivateDnsName
)
privateDNSName
:=
aws
.
StringValue
(
instance
.
PrivateDnsName
)
if
privateDNSName
!=
""
{
if
privateDNSName
!=
""
{
addresses
=
append
(
addresses
,
v1
.
NodeAddress
{
Type
:
v1
.
NodeInternalDNS
,
Address
:
privateDNSName
})
addresses
=
append
(
addresses
,
v1
.
NodeAddress
{
Type
:
v1
.
NodeInternalDNS
,
Address
:
privateDNSName
})
addresses
=
append
(
addresses
,
v1
.
NodeAddress
{
Type
:
v1
.
NodeHostName
,
Address
:
privateDNSName
})
}
}
publicDNSName
:=
aws
.
StringValue
(
instance
.
PublicDnsName
)
publicDNSName
:=
aws
.
StringValue
(
instance
.
PublicDnsName
)
...
...
pkg/cloudprovider/providers/aws/aws_test.go
View file @
0a5f0127
...
@@ -348,13 +348,14 @@ func TestNodeAddresses(t *testing.T) {
...
@@ -348,13 +348,14 @@ func TestNodeAddresses(t *testing.T) {
if
err3
!=
nil
{
if
err3
!=
nil
{
t
.
Errorf
(
"Should not error when instance found"
)
t
.
Errorf
(
"Should not error when instance found"
)
}
}
if
len
(
addrs3
)
!=
4
{
if
len
(
addrs3
)
!=
5
{
t
.
Errorf
(
"Should return exactly
4
NodeAddresses"
)
t
.
Errorf
(
"Should return exactly
5
NodeAddresses"
)
}
}
testHasNodeAddress
(
t
,
addrs3
,
v1
.
NodeInternalIP
,
"192.168.0.1"
)
testHasNodeAddress
(
t
,
addrs3
,
v1
.
NodeInternalIP
,
"192.168.0.1"
)
testHasNodeAddress
(
t
,
addrs3
,
v1
.
NodeExternalIP
,
"1.2.3.4"
)
testHasNodeAddress
(
t
,
addrs3
,
v1
.
NodeExternalIP
,
"1.2.3.4"
)
testHasNodeAddress
(
t
,
addrs3
,
v1
.
NodeExternalDNS
,
"instance-same.ec2.external"
)
testHasNodeAddress
(
t
,
addrs3
,
v1
.
NodeExternalDNS
,
"instance-same.ec2.external"
)
testHasNodeAddress
(
t
,
addrs3
,
v1
.
NodeInternalDNS
,
"instance-same.ec2.internal"
)
testHasNodeAddress
(
t
,
addrs3
,
v1
.
NodeInternalDNS
,
"instance-same.ec2.internal"
)
testHasNodeAddress
(
t
,
addrs3
,
v1
.
NodeHostName
,
"instance-same.ec2.internal"
)
}
}
func
TestNodeAddressesWithMetadata
(
t
*
testing
.
T
)
{
func
TestNodeAddressesWithMetadata
(
t
*
testing
.
T
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment