Unverified Commit 0a59758c authored by Kubernetes Prow Robot's avatar Kubernetes Prow Robot Committed by GitHub

Merge pull request #76549 from xichengliudui/ends-with-newline

Use fmt.printf() to end with a newline
parents 92918dc2 980de9d3
...@@ -50,7 +50,7 @@ func ExamplePhase() { ...@@ -50,7 +50,7 @@ func ExamplePhase() {
} }
// implement your phase logic... // implement your phase logic...
fmt.Printf("%v", d.Data()) fmt.Printf("%v\n", d.Data())
return nil return nil
}, },
} }
...@@ -67,7 +67,7 @@ func ExamplePhase() { ...@@ -67,7 +67,7 @@ func ExamplePhase() {
} }
// implement your phase logic... // implement your phase logic...
fmt.Printf("%v", d.Data()) fmt.Printf("%v\n", d.Data())
return nil return nil
}, },
} }
...@@ -91,7 +91,7 @@ func ExampleRunner_Run() { ...@@ -91,7 +91,7 @@ func ExampleRunner_Run() {
} }
// implement your phase logic... // implement your phase logic...
fmt.Printf("%v", d.Data()) fmt.Printf("%v\n", d.Data())
return nil return nil
}, },
} }
......
...@@ -174,7 +174,7 @@ func BackupAPIServerCertIfNeeded(cfg *kubeadmapi.InitConfiguration, dryRun bool) ...@@ -174,7 +174,7 @@ func BackupAPIServerCertIfNeeded(cfg *kubeadmapi.InitConfiguration, dryRun bool)
// Don't fail the upgrade phase if failing to backup kube-apiserver cert and key, just continue rotating the cert // Don't fail the upgrade phase if failing to backup kube-apiserver cert and key, just continue rotating the cert
// TODO: We might want to reconsider this choice. // TODO: We might want to reconsider this choice.
if err := backupAPIServerCertAndKey(certAndKeyDir); err != nil { if err := backupAPIServerCertAndKey(certAndKeyDir); err != nil {
fmt.Printf("[postupgrade] WARNING: failed to backup kube-apiserver cert and key: %v", err) fmt.Printf("[postupgrade] WARNING: failed to backup kube-apiserver cert and key: %v\n", err)
} }
return certsphase.CreateCertAndKeyFilesWithCA( return certsphase.CreateCertAndKeyFilesWithCA(
&certsphase.KubeadmCertAPIServer, &certsphase.KubeadmCertAPIServer,
......
...@@ -63,7 +63,7 @@ func ParseArgumentListToMap(arguments []string) map[string]string { ...@@ -63,7 +63,7 @@ func ParseArgumentListToMap(arguments []string) map[string]string {
// Warn in all other cases, but don't error out. This can happen only if the user has edited the argument list by hand, so they might know what they are doing // Warn in all other cases, but don't error out. This can happen only if the user has edited the argument list by hand, so they might know what they are doing
if err != nil { if err != nil {
if i != 0 { if i != 0 {
fmt.Printf("[kubeadm] WARNING: The component argument %q could not be parsed correctly. The argument must be of the form %q. Skipping...", arg, "--") fmt.Printf("[kubeadm] WARNING: The component argument %q could not be parsed correctly. The argument must be of the form %q. Skipping...\n", arg, "--")
} }
continue continue
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment