Replace `false` with `exit 1`

Some scripts contained `false` for returning 1 to callers instead of `exit 1` and that works like: $ false $ echo $? 1 $ But that made confusion in a PR review process. So this replaces `false` with `exit 1` for long-term maintenance.

Replace `false` with `exit 1`
08dc0564 · Kenichi Omichi · db5d390d · 08dc0564 · 08dc0564
Commit 08dc0564 authored Apr 16, 2019 by Kenichi Omichi
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

verify-golint.sh hack/verify-golint.sh +3 -3

verify-shellcheck.sh hack/verify-shellcheck.sh +3 -3

No files found.
--- a/hack/verify-golint.sh
+++ b/hack/verify-golint.sh
@@ -94,7 +94,7 @@ else
    echo 'checking by adding it to hack/.golint_failures (if your reviewer is okay with it).'
    echo
  } >&2
-  false
+  exit 1
 fi

 if [[ ${#not_failing[@]} -gt 0 ]]; then
@@ -106,7 +106,7 @@ if [[ ${#not_failing[@]} -gt 0 ]]; then
    done
    echo
  } >&2
-  false
+  exit 1
 fi

 if [[ ${#gone[@]} -gt 0 ]]; then
@@ -118,5 +118,5 @@ if [[ ${#gone[@]} -gt 0 ]]; then
    done
    echo
  } >&2
-  false
+  exit 1
 fi
--- a/hack/verify-shellcheck.sh
+++ b/hack/verify-shellcheck.sh
@@ -169,7 +169,7 @@ else
    echo 'checking by adding it to hack/.shellcheck_failures (if your reviewer is okay with it).'
    echo
  } >&2
-  false
+  exit 1
 fi

 if [[ ${#not_failing[@]} -gt 0 ]]; then
@@ -181,7 +181,7 @@ if [[ ${#not_failing[@]} -gt 0 ]]; then
    done
    echo
  } >&2
-  false
+  exit 1
 fi

 # Check that all failing_packages actually still exist
@@ -199,5 +199,5 @@ if [[ ${#gone[@]} -gt 0 ]]; then
    done
    echo
  } >&2
-  false
+  exit 1
 fi